Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add router implementation note #2935

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

Drewbi
Copy link
Contributor

@Drewbi Drewbi commented Jun 15, 2020

Motivation

A few people were unaware that the @docusaurus/router supported all the features that come with React Router as it is a re-export.

Have you read the Contributing Guidelines on pull requests?

Yes

Updated Section

I added a note clarifying the implementation and features of the router.
Doc Screen shot

Related Issues

resolves #2562

@Drewbi Drewbi requested a review from yangshun as a code owner June 15, 2020 05:05
@facebook-github-bot
Copy link
Contributor

Hi @Drewbi!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit fe52022

https://deploy-preview-2935--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 15, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber merged commit c341f45 into facebook:master Jun 15, 2020
@slorber
Copy link
Collaborator

slorber commented Jun 15, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] document the programmatic navigation API
4 participants