-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): Implement a simple E2E testing mechanism for docusausus start
#2950
chore(v2): Implement a simple E2E testing mechanism for docusausus start
#2950
Conversation
Deploy preview for docusaurus-2 ready! Built with commit e78f830 |
Looks like the new integration test is already catching some problems. See https://github.com/facebook/docusaurus/pull/2950/checks?check_run_id=778802180. #2884 introduced some nullish coalescing syntax that the current babel loader doesn't like. |
LGTM Hey, wasn't aware of this "test-website" e2e tests. Wonder if it's not worth it to do the same for the bootstrap theme as well? @fanny |
Interesting, I think that would be great, I'll work on |
Motivation
Implement a simple mechanism to E2E test
docusausus start
, so that we can catch no-prod only issues at diff time (avoid things like #2944). It uses thedone
webpack compiler hook to ensure that webpack can compile without errors. In this way, we can completely rule out disasters like #2883.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run
E2E_TEST yarn start --no-open
on the following scanarios:Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)