-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add support for serve command #3080
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 7d051d4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks nice thanks.
I'd rather use the existing choosePort fn
Also need to add some doc :)
Thanks, that looks great to merge. I think we should add more documentation for this. For example: https://v2.docusaurus.io/docs/cli/#docusaurus-build I think it would be nice for discoverability to enhance this message with something like "hey, use |
@slorber I don't think we shouldn't add it as a self-hosting solution. It is always ideal to use a load balancer or some production-ready software to serve these resources. |
I think we should add it, and add a caution admonition to tell the user that it may not be the most performant option. Some users simply know what they are doing, and would be happy to know it's possible to self host the thing. I'm pretty sure someone at some point will run docusaurus on a raspberry pi :p |
done |
thanks :) |
Motivation
The easy serving of build directory. Fix #3062
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Simple Serve
Combining Build