Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): allow to use array of files in customCss field #3474

Merged
merged 2 commits into from
Sep 28, 2020
Merged

feat(v2): allow to use array of files in customCss field #3474

merged 2 commits into from
Sep 28, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Sep 23, 2020 •
edited
Loading

Motivation

This small PR fixes the issue with server build when array of files was specified in customCss field in the theme classic preset configuration.

CC @slorber

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Successful server build of React Native website with multiple files in customCss.

Related PRs

@Simek Simek requested a review from lex111 as a code owner September 23, 2020 11:04
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 23, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 23, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 44ef7f5

https://deploy-preview-3474--docusaurus-2.netlify.app

@lex111
Copy link
Contributor

lex111 commented Sep 23, 2020

@Simek your PR resolves #3416?

@Simek
Copy link
Contributor Author

Simek commented Sep 23, 2020 •
edited
Loading

@lex111 Yup, this PR should fix the mentioned issue by you too, but I have not added the Joi validator as Sebastien suggested in there.

@lex111
Copy link
Contributor

lex111 commented Sep 23, 2020

@Simek will you do that? Also we need to update the docs.

@Simek
Copy link
Contributor Author

Simek commented Sep 23, 2020 •
edited
Loading

@lex111 I'm not sure how to do this correctly, since customCss field is a part of presets.theme config, not themeConfig (and it's not validated in any way right now).

Also it looks like an additional schema will be needed in docusaurus-utils-validation, but to be honest I'm not that familiar with Joi.

@lex111
Copy link
Contributor

lex111 commented Sep 23, 2020

I'm not very good at this either, alright, so let's wait until Sebastien comes back from vacation.

@anshulrgoyal
Copy link
Contributor

For Joi validation add it in the classic theme option validation.

@ghost ghost mentioned this pull request Sep 23, 2020
Closed
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Sep 28, 2020
@slorber
customCss array:
44ef7f5 
- fix bug (push instead of concat)
- update docs
- add theme config validation + tests
@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

Hey, I've added the validation. Also fixed a bug because using concat instead of push was no-op :)

@slorber slorber linked an issue Sep 28, 2020 that may be closed by this pull request
CSS support - being able to call an array of CSS files in the config #3416
Closed
@slorber slorber merged commit ae2c063 into facebook:master Sep 28, 2020
slorber added a commit that referenced this pull request Sep 29, 2020
@Simek @slorber
feat(v2): allow to use array of files in customCss field (#3474)
93f0f39 
* feat(v2): allow to use array of files in customCss field

* customCss array:
- fix bug (push instead of concat)
- update docs
- add theme config validation + tests

Co-authored-by: slorber <[email protected]>
@lex111 lex111 added this to the v2.0.0-alpha.65 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
v2.0.0-alpha.65
Development

Successfully merging this pull request may close these issues.

CSS support - being able to call an array of CSS files in the config
6 participants
@Simek @docusaurus-bot @lex111 @anshulrgoyal @slorber @facebook-github-bot