fix: add repository metadata to all packages #3613
Conversation
|
Hi @rarkins! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| const glob = util.promisify(globCb); | ||
| const readFile = util.promisify(fsCb.readFile); | ||
|
|
||
| describe('packages', () => { |
There was a problem hiding this comment.
Feel free to move/refactor/etc this test. Without it, things are likely to get out of sync again.
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 0cee011 |
|
Deploy preview for docusaurus-2 ready! Built with commit 9e4b0ea |
There is one error to fix. |
|
@lex111 it's in devDependencies, which is where I think it belongs. Maybe this lint error is because it's in |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Sorry, I'm not sure how to fix this. Jest spec files shouldn't have a |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks, seems to be passing now ;) |
slorber
added
the
pr: maintenance
| @@ -100,6 +100,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.2.3", | |||
| "eslint-plugin-react": "^7.20.0", | |||
| "eslint-plugin-react-hooks": "^4.0.4", | |||
| "glob": "^7.1.6", | |||
There was a problem hiding this comment.
Thanks. I was sure I'd add this already. Spent hours thinking it wanted me to move the dependency into dependencies and trying to fix that.. ugh
There was a problem hiding this comment.
:) maybe you didn't use the -W option to add dev dependencies in monorepo root ;)
Closes #3612
Motivation
Ensure all npm packages now and in the future contain accurate repository metadata.
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
This PR includes its own test, so I think just code inspection is OK.
Related PRs
None