Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add missing 'react' and 'webpack' peer dependencies #3675

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Nov 2, 2020

Motivation

  • mdx-loader, plugin-google-analytics, plugin-google-gtag, and docusaurus-plugin-sitemap depends on @docusaurus/core, which peer-depends on react and react-dom (@mdx-js/react peer-depends on react@^16.13.1)
  • mdx-loader depends on file-loader and url-loader, which peer-depends on webpack
    (Write your motivation here.)

so they should be listed as peer dependencies.

Note other packages also list them as peer dependencies:

"peerDependencies": {
"react": "^16.8.4",
"react-dom": "^16.8.4"
},

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check following warnings are not shown in Yarn 2 E2E test (https://github.com/facebook/docusaurus/pull/3675/checks?check_run_id=1343372025#step:6:308):

  ➤ YN0002: │ @docusaurus/plugin-google-analytics@npm:2.0.0-alpha.66.NEW doesn't provide react-dom@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/plugin-google-analytics@npm:2.0.0-alpha.66.NEW doesn't provide react@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/plugin-google-gtag@npm:2.0.0-alpha.66.NEW doesn't provide react-dom@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/plugin-google-gtag@npm:2.0.0-alpha.66.NEW doesn't provide react@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/plugin-sitemap@npm:2.0.0-alpha.66.NEW doesn't provide react-dom@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/plugin-sitemap@npm:2.0.0-alpha.66.NEW doesn't provide react@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/mdx-loader@npm:2.0.0-alpha.66.NEW doesn't provide react-dom@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/mdx-loader@npm:2.0.0-alpha.66.NEW doesn't provide react@^16.8.4 requested by @docusaurus/core@npm:2.0.0-alpha.66.NEW
  ➤ YN0002: │ @docusaurus/mdx-loader@npm:2.0.0-alpha.66.NEW doesn't provide react@^16.13.1 requested by @mdx-js/react@npm:1.6.19
  ➤ YN0002: │ @docusaurus/mdx-loader@npm:2.0.0-alpha.66.NEW doesn't provide webpack@^4.0.0 || ^5.0.0 requested by file-loader@npm:6.2.0
  ➤ YN0002: │ @docusaurus/mdx-loader@npm:2.0.0-alpha.66.NEW doesn't provide webpack@^4.0.0 || ^5.0.0 requested by url-loader@npm:4.1.1

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 2, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 0f10713

https://deploy-preview-3675--docusaurus-2.netlify.app

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 2, 2020
@slorber slorber merged commit 1bba6b1 into facebook:master Nov 2, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 2, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants