fix(v2): add missing 'react' and 'webpack' peer dependencies #3675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
mdx-loader
,plugin-google-analytics
,plugin-google-gtag
, anddocusaurus-plugin-sitemap
depends on@docusaurus/core
, which peer-depends onreact
andreact-dom
(@mdx-js/react
peer-depends onreact@^16.13.1
)mdx-loader
depends onfile-loader
andurl-loader
, which peer-depends onwebpack
(Write your motivation here.)
so they should be listed as peer dependencies.
Note other packages also list them as peer dependencies:
docusaurus/packages/docusaurus-plugin-debug/package.json
Lines 25 to 28 in 3242549
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check following warnings are not shown in Yarn 2 E2E test (https://github.com/facebook/docusaurus/pull/3675/checks?check_run_id=1343372025#step:6:308):
Related PRs