Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove aria-hidden attr from anchor link of heading #3806

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 23, 2020

Motivation

Fixes a11y error of "ARIA hidden element must not contain focusable elements".

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Nov 23, 2020
@lex111 lex111 requested a review from slorber as a code owner November 23, 2020 21:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2020
@netlify
Copy link

netlify bot commented Nov 23, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 618ca71

https://deploy-preview-3806--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: -3 B (0%)

Total Size: 154 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -5 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB +2 B (0%)
website/build/main.********.js 110 kB 0 B
website/build/styles.********.css 17.3 kB 0 B

compressed-size-action

@lex111 lex111 merged commit 9ca85cf into master Nov 23, 2020
@lex111 lex111 deleted the lex111/remove-aria-hidden-anchor branch November 23, 2020 21:53
@lex111 lex111 added this to the v2.0.0-alpha.69 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants