fix(v2): Fix double trailingSlash in sitemap.xml #4004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where when
trailingSlash
option is enabled, routes that already end in a/
are shown with double slash at the end.Motivation
Some of my routes show in sitemap.xml without a trailing slash, so I use
trailingSlash
to make them all consistent. However, some of my paths (e.g. /docs/ created by getting_started.md) already have a trailing slash. Currently /docs/ will be rendered as/docs//
in the sitemap which isn't correct. This fix prevents that trailing double slash when thetrailingSlash
option is enabled.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
trailingSlash
option/docs
withslug: /
build/sitemap.xml
entry generated for/docs/
doesn't have a trailing slashRelated PRs
N/A