Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add hideableSidebar option to config demo #4009

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 7, 2021

Motivation

Wanted to see how I can get the hideable sidebar that Docusaurus has on their website.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Size Change: -2 B (0%)

Total Size: 26.7 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.83 kB -1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 7, 2021

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 0effa61

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ffc637bb084be00082cee88

😎 Browse the preview: https://deploy-preview-4009--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4009--docusaurus-2.netlify.app/classic/

@natac13 natac13 changed the title docs: add hideableSidebar option to config demo docs(v2): add hideableSidebar option to config demo Jan 7, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 11, 2021

thanks

Edited because the documented values should rather be the default ones by default and you wrongly put the hideableSidebar: true, under the "colorMode" config attribute

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 11, 2021
@slorber slorber merged commit af8dc63 into facebook:master Jan 19, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants