Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(v2): improve codesandbox template package.json #4074

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jan 20, 2021

Motivation

We want to avoid having a bad name in codesandbox UI:

image

Also add some useful MD docs + minor details

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 20, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 20, 2021
@netlify
Copy link

netlify bot commented Jan 20, 2021

✔️ [V1] Deploy preview success

🔨 Explore the source changes: 7c4ce62

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/600816a67d7aef00088eeef2

😎 Browse the preview: https://deploy-preview-4074--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2021

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 7c4ce62

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/600816a66e4e340007a965e9

😎 Browse the preview: https://deploy-preview-4074--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: -4 B (0%)

Total Size: 27.1 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.9 kB -3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.02 kB -1 B (0%)

compressed-size-action

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4074--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit eeb167e into master Jan 20, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/better-codesandbox-templates branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants