Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): restore hamburger menu #4195

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 8, 2021

Motivation

Relates to #4194 (comment)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner February 8, 2021 16:03
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

Size Change: +16 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.94 kB -1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 1587b84

https://deploy-preview-4195--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 83
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4195--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit fc071b0 into facebook:master Feb 8, 2021
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 8, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 8, 2021

LGTM!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants