Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): bump/align deps in monorepo: commander, semver, fs-extra #4264

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Feb 22, 2021

Motivation

This is the first of "N" PRs in which I'm trying to cleanup the Docusaurus workspace, normalize and if possible reduce number of dependencies, check for some redundancies which might were created during rapid development in the last months.

This PR normalizes the version of three packages across the workspace (skipping V1 packages):

To make the reviews easier I'm trying to keep the batches in PRs quite small, so

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Successful build on local machine + successful Docusaurus 2 website start on localhost.

Related PRs

Not yet.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 22, 2021
@netlify
Copy link

netlify bot commented Feb 22, 2021

@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 39b5459

https://deploy-preview-4264--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4264--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: 0 B

Total Size: 543 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 86.6 kB 0 B
website/build/assets/js/main.********.js 370 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.5 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 22, 2021

LGTM, seems safe to merge.

FYI, as there's an ongoing Webpack 5 migration, and we'll also remove v1 from master soon, I'd prefer to avoid too complex deps refactorings in the near future

Also found this package useful to "align deps versions" across a monorepo, but couldn't apply it to docusaurus when I tried it a few months ago (had other errors that I couldn't solve immediately, may be worth trying again) https://github.com/Thinkmill/manypkg

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 22, 2021
@slorber slorber changed the title chore: use the same version of package across the workspace (skip v1) chore(v2): use the same version of package across the workspace (skip v1) Feb 22, 2021
@slorber slorber changed the title chore(v2): use the same version of package across the workspace (skip v1) chore(v2): bump/align commander, semver, fs-extra (skip v1) Feb 22, 2021
@slorber slorber changed the title chore(v2): bump/align commander, semver, fs-extra (skip v1) chore(v2): bump/align deps in monorepo: commander, semver, fs-extra Feb 22, 2021
@slorber slorber merged commit bd3e66d into facebook:master Feb 22, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants