fix(v2): remove no longer used postcss-present-env from dependencies #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 7185fae https://app.netlify.com/sites/docusaurus-1/deploys/605ad710b127df0008512da5 |
armano2
force-pushed
the
fix/postcss-present-env
branch
from
5176da1
to
7185fae
Compare
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 5176da1 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4506--docusaurus-2.netlify.app/ |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 7185fae |
armano2
commented
Mar 24, 2021
| plugins: [ | ||
| require('postcss-preset-env')({ | ||
| autoprefixer: { | ||
| flexbox: 'no-2009', | ||
| }, | ||
| stage: 4, | ||
| }), | ||
| ], | ||
| plugins: [require('autoprefixer')], |
There was a problem hiding this comment.
docusaurus/packages/docusaurus/src/webpack/utils.ts
Lines 75 to 83 in 819bb43
2 tasks
|
thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
postcss-present-envis no longer used after changes done in #4355, this pr updates documentation and removes this package from dependenciesthis change has been extracted from #4404
https://github.com/facebook/docusaurus/pull/4355/files#diff-0c33a9be9b9aca4b4536266cc9c2b8db8131f03a7bc2cec8c5ccf27ea63cbc82L76-R76
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
#4355, #4404