Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase meli #4704

Merged
merged 3 commits into from
Apr 30, 2021
Merged

docs(v2): showcase meli #4704

merged 3 commits into from
Apr 30, 2021

Conversation

gempain
Copy link
Contributor

@gempain gempain commented Apr 29, 2021

Motivation

We'd like to add Meli to the showcase section.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I just added a new entry in users.js + a showcase image

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 29, 2021
@netlify
Copy link

netlify bot commented Apr 29, 2021

[V2]

Built with commit 9800b70

https://deploy-preview-4704--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 29, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 80
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4704--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 30, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

will just update the site url

title: 'Meli',
description: 'Platform to deploy static sites, frontend applications and hosted forms',
preview: require('./showcase/meli.png'),
website: 'https://github.com/getmeli/meli',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This website link should not target a github repo but the real website

website/src/data/users.js Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Apr 30, 2021

[V1]

Built with commit 9800b70

https://deploy-preview-4704--docusaurus-1.netlify.app

@slorber slorber merged commit 27b9f34 into facebook:master Apr 30, 2021
@slorber slorber changed the title feat: showcase meli docs(v2): showcase meli Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants