refactor(v2): cleanup console output #4979
Conversation
lex111
added
the
pr: polish
| console.log(); | ||
| console.log(chalk.cyan(' cd'), cdpath); | ||
| console.log(` ${chalk.cyan(`${pkgManager} start`)}`); | ||
|
|
||
| console.log(); | ||
| console.log('Happy hacking!'); | ||
| console.log('Happy building awesome websites!'); |
There was a problem hiding this comment.
It's an attempt to distinguish from the CRA, I think it's fine to have an original slogan.
|
✔️ [V2] 🔨 Explore the source changes: 37568d7 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c9bcc1c2b7290007ee9b54 😎 Browse the preview: https://deploy-preview-4979--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4979--docusaurus-2.netlify.app/ |
|
Size Change: +5 B (0%) Total Size: 624 kB ℹ️ View Unchanged
|
|
I don't really understand why the tests do not pass successfully, because snapshots do not differ 🤷♂️
|
Not sure what happened but Jest doesn't seem to like my test factorization much so I removed it and restored a bit of duplication, now the snapshots pass and can be updated |
Motivation
Attempting to tidy up any output in the console that Docusaurus codebase produces.
Main points:
[]or=, and use a more user-friendly style of spelling instead (i.e.=[',']->",")Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Snapshots?
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)