Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix webpack SSG plugin error thrown due to new URL() / __filename #5059

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 25, 2021

Motivation

Quite complicated to explain, fixes #4922 (including all the relevant details)

Not sure it's the perfect fix, but it looks to me we can pass any __filename value to unlock the situation, and it has no particular effect in practice apart preventing the eval error

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local test + feedback from Relay Compiler playground integration, using Rust/WASM compiler

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 25, 2021
@slorber slorber requested a review from lex111 as a code owner June 25, 2021 09:09
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 25, 2021
@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ [V2]

🔨 Explore the source changes: efa3c76

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d59d5b4253230007dc35d8

😎 Browse the preview: https://deploy-preview-5059--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5059--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 601 kB

ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.7 kB
website/build/assets/js/main.********.js 415 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.5 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 31.3 kB

compressed-size-action

@slorber slorber merged commit 67d31f4 into master Jun 25, 2021
@slorber slorber deleted the slorber/fix-ssg-plugin-__filename branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Prerendering fails when dependency includes new URL('empty.js', import.meta.url);
2 participants