fix(v2): never remove trailing slash from site root like '/baseUrl/' #5082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5077
With
baseUrl = /xyz/
andtrailingSlash: false
, we should never transform the root route to/xyz
Otherwise the output folder will contain
website/build/xyz.html
instead ofwebsite/build/index.html
Trailing slash config should only apply to subroutes of the site, not the root / baseUrl / homepage of the site, or it can lead to 404 server errors
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests + dogfooding on our i18n sites (using locale baseurl)