Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): pass all props to CodeBlock component #5183

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jul 15, 2021

Motivation

Fixes #5180

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See reproducible steps from #5180

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jul 15, 2021
@lex111 lex111 requested a review from slorber as a code owner July 15, 2021 21:40
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 15, 2021
@netlify
Copy link

netlify bot commented Jul 15, 2021

✔️ [V2]

🔨 Explore the source changes: b8aa932

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60f0ab34c5215500081f06f3

😎 Browse the preview: https://deploy-preview-5183--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5183--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -6 B (0%)

Total Size: 850 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 58.8 kB 0 B
website/build/assets/css/styles.********.css 89 kB 0 B
website/build/assets/js/main.********.js 459 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.4 kB 0 B
website/build/blog/index.html 26.3 kB 0 B
website/build/docs-tests/index.html 20.3 kB 0 B
website/build/docs-tests/standalone/index.html 18.8 kB 0 B
website/build/docs/index.html 40.2 kB -3 B (0%)
website/build/docs/installation/index.html 47.8 kB -3 B (0%)
website/build/index.html 27.3 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jul 16, 2021

👍

@slorber slorber merged commit 44225a3 into master Jul 16, 2021
@slorber slorber deleted the lex111/iss5180 branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

className prop is not passed to the CodeBlock component
3 participants