Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add quickwit to user.js and png. #5187

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Jul 16, 2021

Motivation

Quickwit is using Docusaurus v2 for its website and documentation with a great design. This is a good example of how you can do what you want with your awesome framework. Thanks again for doing this.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start and check that the page http://localhost:3000/showcase is rendered properly.
Note: the images of all websites were not showing though.

Related PRs

No

@facebook-github-bot
Copy link
Contributor

Hi @fmassot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Jul 16, 2021

✔️ [V2]

🔨 Explore the source changes: 4477c6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60f14ddfec5d2d0008bca236

😎 Browse the preview: https://deploy-preview-5187--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 16, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5187--docusaurus-2.netlify.app/

@slorber slorber changed the title Add quickwit to user.js and png. docs(v2): Add quickwit to user.js and png. Jul 16, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ❤️ beautiful site! directly in favorites

Now just waiting for the required CLA check

website/src/data/users.js Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 16, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 16, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber merged commit cda0923 into facebook:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants