fix(v2): keep mobile TOC after hydration #5229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After we merged the new mobile UX, anchor links in headings broke. The reason for this is that during prerendering we render mobile TOC to avoid layout shift, but after hydration mobile TOC is removed from DOM on desktop. However, this is wrong because we hide mobile TOC on desktop with CSS. Therefore, we need to always render mobile TOC, then anchor links will work again and we still won't have FOUC.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Test mobile TOC, then open any anchor link in new tab.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)