Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): make hash link in heading not selectable #6000

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

Jess-2021
Copy link
Contributor

@Jess-2021 Jess-2021 commented Nov 24, 2021

Motivation

Fix #5990. I added an attribute about 'user-select' to the hash-link class. And it can help me to copy the text without worrying about ZWSP.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Manual verification.

@facebook-github-bot
Copy link
Contributor

Hi @JararvisQ!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: a32ccd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619df48055e779000841981b

😎 Browse the preview: https://deploy-preview-6000--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 24, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6000--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title fix: bug fix for ZWSP (fix #5990) fix: make hash link in heading not selectable Nov 24, 2021
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 24, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 24, 2021
@Josh-Cena
Copy link
Collaborator

Thanks, makes sense

Congrats on making issue #6000 :D

@Josh-Cena Josh-Cena merged commit 48fff3e into facebook:main Nov 24, 2021
@Josh-Cena Josh-Cena changed the title fix: make hash link in heading not selectable fix(theme-classic): make hash link in heading not selectable Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About zero-width space(ZWSP)
3 participants