-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add docusaurus deploy CI tests #7714
base: main
Are you sure you want to change the base?
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
Size Change: 0 B Total Size: 802 kB ℹ️ View Unchanged
|
@@ -14,6 +14,8 @@ import {hasSSHProtocol, buildSshUrl, buildHttpsUrl} from '@docusaurus/utils'; | |||
import {loadContext, type LoadContextOptions} from '../server'; | |||
import {build} from './build'; | |||
|
|||
// Test temporary comment to trigger CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the workflow file to trigger conditions as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :D better idea
Will have to figure out if we still have a deploy token set on this repo 😅 Not sure we could run this workflow on external PRs, as we'd need a user to push to the origin? 🤷♂️ |
Pre-flight checklist
Motivation
As mentioned in #7702, we don't have any automated way to ensure our deploy CLI keeps working over time, and any modification usually requires manual tests to ensure nothing gets broken.
These CLI scripts are not really easy to test as they usually run multiple complex Git commands.
I suggest we run as part of our CI tests to deploy a build dir to a real Git repo branch, ensuring at least the "happy path" of that script keeps working over time.
Test Plan
CI