-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(showcase): add 74 new showcase sites #8010
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +100 B (0%) Total Size: 814 kB
ℹ️ View Unchanged
|
All Docusaurus sites submitted have been added in the PR, or rejected with a comment Ping all submitters: |
The green ones are selected. Maybe there isn't enough contrast difference for color-blind folks—I would fix that by adding an icon soon. |
As a colour-blind person, I can confirm. It's only a problem in dark-mode. I expected the buttons to change somehow - perhaps to go from an outlined circle to a filled circle (though that has other issues). Perhaps inverting the colour? |
Right. Here's what I made for the TS-ESLint website: https://typescript-eslint.io/rules/ |
That works well. I can see that ;). Thanks. |
@andrewnicols this is not really a good place to discuss showcase page accessibility issues I'll keep this in mind, but it would be better to open a dedicated issue, and suggest a proposal that works for you |
Motivation
Add all new showcase submissions above comment #7826 (comment)
FYI we are moving site screenshots to a serverless screenshot service.
For example: https://slorber-api-screenshot.netlify.app/https%3A%2F%2Fdocusaurus.io%2F/showcase
Will render:
We know about some limitations of the screenshot service:
We are going to ship it as is for now, and improve it over time so that all sites in our showcase render nicely