-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention docusaurus.community site in resources #8943
Conversation
- Adds Community https://Docusaurus.community site
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
I have no idea how to fix the info admonition autocorrecting! It's supposed to look like this:
So that it's not super bolded as an info title for the whole 1st sentence! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs an entire page. Just putting it in "resources" is good enough.
Co-authored-by: Joshua Chen <[email protected]>
@thadguidry This is because of Prettier autoformatting. Please see https://docusaurus.io/docs/markdown-features/admonitions#usage-with-prettier |
Prettier extension is disabled in my VSCode and yet something is still autocorrecting the info admonition formatting once I click on commit (but not push yet). |
We have a husky hook that automatically runs Prettier on pre-commit. |
@thadguidry Please, please read https://docusaurus.io/docs/markdown-features/admonitions#usage-with-prettier — even if you hack around the pre-commit hook, this style will be rejected by the CI. All you need to do is add line breaks around the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Ok to add this once you are ready with the text
Pre-flight checklist
Motivation
https://Docusaurus.community site should be mentioned under Community.
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
Fixes #8939