-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme-common): code block MagicComments support for TeX/LaTeX/Matlab #8982
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This pattern is inherited from TeX so let's call the style tex
and add tex
and latex
to the language list.
Thank you for the feedback! |
LGTM thanks 👍 |
Thanks for the review and for pushing up the missing quote! 😊 |
Pre-flight checklist
Motivation
I could not see an open issue for it but I would like to be able to use the magic comments feature in Matlab code blocks. This isn't currently supported due to Matlab's way of commenting, therefore I have added this capability in this PR.
Test Plan
dogfooding page which verifies the functionality.
before
after
Test links
Deploy preview: https://deploy-preview-8982--docusaurus-2.netlify.app/tests/pages/code-block-tests/#magic-comments-tests
Related issues/PRs