set IMPORTED_LINK_INTERFACE_LIBRARIES to ${LIBGFLAGS_LIBRARY} for glog::glog #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D39220438 |
…g::glog (facebook#31) Summary: Pull Request resolved: facebook#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: d68bb6ad526782b24d8343a9467f059e2cb09f51
Atry
force-pushed
the
export-D39220438
branch
from
e9d0f50 to
719ff4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39220438 |
Atry
added a commit
to Atry/folly
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: aff7813e39927d031bcf2ca998f817f1802f65bb
Atry
added a commit
to Atry/edencommon
that referenced
this pull request
Sep 1, 2022
…g::glog (#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: c45138a8ba4fc8544828028d3a14f5431a615463
This was referenced Sep 1, 2022
Atry
added a commit
to Atry/proxygen
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: efcdc5f659bf53519573a750072731ad07919411
Atry
added a commit
to Atry/openr
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 579c3b8c4a9ee9f250c6678f28d40b8269bc4c4a
Atry
added a commit
to Atry/watchman
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 61b968e4715a15e784c8cc838395e8c173dbf9f0
Atry
added a commit
to Atry/fizz
that referenced
this pull request
Sep 1, 2022
…g::glog (#1854) Summary: X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: e173e039d58725200ad14e3cb28b4ca41d71e3ac
Atry
added a commit
to Atry/rust-shed
that referenced
this pull request
Sep 1, 2022
…g::glog (facebookexperimental#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: d269c8e50ed20541054ea706394450043f8181ef
Atry
added a commit
to Atry/mvfst
that referenced
this pull request
Sep 1, 2022
…g::glog (#1055) Summary: X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 24daf09e18907b0d3663419e5fb749e89bafc02e
Atry
added a commit
to Atry/katran
that referenced
this pull request
Sep 1, 2022
…g::glog (facebookincubator#34) Summary: X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 4c97d3a2a04b3b8ff56a111246d43440a08a78a0
Atry
added a commit
to Atry/fbthrift
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#31) Summary: X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 68dbd17ce51faa100e780d777f70fc946b44beb7
Atry
added a commit
to Atry/hsthrift
that referenced
this pull request
Sep 1, 2022
…g::glog (facebookincubator#34) Summary: X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: d48193945e87cf0fddf3309d594116ec580c92b8
Atry
added a commit
to Atry/wangle
that referenced
this pull request
Sep 1, 2022
…g::glog (#272) Summary: X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 97f9809955bb473eb38c49d23708f30d25c325c8
Atry
added a commit
to Atry/reindeer
that referenced
this pull request
Sep 1, 2022
…g::glog (#272) Summary: X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: f924e27d0a0c2497eb5e11fab5bbaa8dbceec13b
Atry
added a commit
to Atry/velox
that referenced
this pull request
Sep 1, 2022
…g::glog (facebookincubator#4) Summary: X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: 819114858fa46367d9eed9b71c1d47bb51e30d4d
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Sep 1, 2022
…g::glog (facebook#118) Summary: X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Differential Revision: D39220438 fbshipit-source-id: fade756b0db0e1ccdb50dcc334ac345c0a8c54e5
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 Pull Request resolved: #98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 Pull Request resolved: #34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 Pull Request resolved: #4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 Pull Request resolved: #118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 Pull Request resolved: #521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 Pull Request resolved: #127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 Pull Request resolved: #1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 Pull Request resolved: #140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 Pull Request resolved: #2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 Pull Request resolved: #4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 Pull Request resolved: #208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 Pull Request resolved: #81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 Pull Request resolved: #272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: Pull Request resolved: #9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 X-link: facebookincubator/katran#171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 Pull Request resolved: #1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since 4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Sep 7, 2022
…::glog (#9169) Summary: X-link: facebook/hhvm#9169 X-link: facebook/wangle#208 X-link: facebookincubator/reindeer#4 X-link: facebookincubator/velox#2445 X-link: facebookincubator/hsthrift#98 Pull Request resolved: #171 X-link: facebook/mvfst#272 X-link: facebook/fboss#118 X-link: facebookincubator/fizz#81 X-link: facebook/sapling#127 X-link: facebookarchive/sapling-staging#7 X-link: facebookexperimental/edencommon#4 X-link: facebookexperimental/rust-shed#34 X-link: facebook/fbthrift#521 X-link: facebook/watchman#1055 X-link: facebook/folly#1854 X-link: facebook/openr#140 X-link: facebook/fb303#31 Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, `glog` should solve the `GflagsFlagSaver` symbol directly from `gflags`. This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`. Reviewed By: alexeyt Differential Revision: D39220438 fbshipit-source-id: 485d67bfeace955f83a4961372680f12eb9cc1a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously Folly provided a polyfill of the
GflagsFlagSaversymbol, which was removed since facebook/folly@4dadde1. Therefore, theglogshould solve theGflagsFlagSaversymbol fromgflags.This diff added gflags libraries as a dependency of the CMake project
glog::glog, so that the glog users will be able to automatically link with gflags.Differential Revision: D39220438