Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React lifecycles getDerivedStateFromProps, getSnapshotBeforeUpdate #6511

Closed
wants to merge 5 commits into from
Closed

Add React lifecycles getDerivedStateFromProps, getSnapshotBeforeUpdate #6511

wants to merge 5 commits into from

Commits on Jun 23, 2018

  1. Add React lifecycles getDerivedStateFromProps, getSnapshotBeforeUpdate 

    Closes facebook#6101, closes facebook#6104.
    @motiz88
    motiz88 committed Jun 23, 2018
    Configuration menu
    Copy the full SHA
    3b08afc View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. Merge remote-tracking branch 'facebook/master' into react-16.3-lifecy… 

    …cles
    @motiz88
    motiz88 committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    d854b47 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. Merge remote-tracking branch 'facebook/master' into react-16.3-lifecy… 

    …cles
    @motiz88
    motiz88 committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    73a496a View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2018

  1. Merge remote-tracking branch 'facebook/master' into react-16.3-lifecy… 

    …cles
    @motiz88
    motiz88 committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    2b55d98 View commit details
    Browse the repository at this point in the history

  2. Improve getSnapshotBeforeUpdate, getDerivedStateFromProps return types 

    A couple of remaining issues due to facebook#6606:
- gDSFP's return type is correct, but in need of a cleanup once
$NonMaybeType<$Shape<State>> works.
- gSBU's return type still allows undefined, which should be rejected.

I have made these explicit in the code by using $FIXME-prefixed aliases.
    @motiz88
    motiz88 committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    8a7bb7d View commit details
    Browse the repository at this point in the history