Extract public key portion via PEM roundtrip #9282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3 Pull Request resolved: facebook#9282 Test Plan: The existing tests should still pass with OpenSSL 1.1 ``` "$HHVM_BIN" hphp/test/run.php hphp/test/slow/ext_openssl/ext_openssl.php ``` For OpenSSL 3 compatibility, this diff should be tested along with D40775247. Differential Revision: D40876120 Pulled By: Atry fbshipit-source-id: 33f831f7c7b94876a7f67ff2e6c53d8026aa9129
Atry
force-pushed
the
duplicate-public-key
branch
from
105183b
to
5e1b1bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40876120 |
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Nov 2, 2022
Summary: This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3 Pull Request resolved: facebook#9282 Test Plan: The existing tests should still pass with OpenSSL 1.1 ``` "$HHVM_BIN" hphp/test/run.php hphp/test/slow/ext_openssl/ext_openssl.php ``` Differential Revision: D40876120 Pulled By: Atry fbshipit-source-id: 402e333b76853d70931f6898dd15ae9e88d8ecd8
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Nov 2, 2022
Summary: This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3 Pull Request resolved: facebook#9282 Test Plan: The existing tests should still pass with OpenSSL 1.1 ``` "$HHVM_BIN" hphp/test/run.php hphp/test/slow/ext_openssl/ext_openssl.php ``` Differential Revision: D40876120 Pulled By: Atry fbshipit-source-id: a0d7d9932da78f06b986096f45a03d169331f38c
|
@Wilfred Why do you close this PR? This PR is necessary to port HHVM to OpenSSL 3, and it is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3
Test Plan
The existing tests should still pass with OpenSSL 1.1