Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributing Guideline #147

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Add Contributing Guideline #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93c9901
Add Contributing Guideline
Huxpro Mar 8, 2022
2364b71
fixup: [spec] `npm run build`
Huxpro Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,28 @@ Prior Art

The JSX syntax is similar to the [E4X Specification (ECMA-357)](http://www.ecma-international.org/publications/files/ECMA-ST-WITHDRAWN/Ecma-357.pdf). E4X is a deprecated specification with deep reaching semantic meaning. JSX partially overlaps with a tiny subset of the E4X syntax. However, JSX has no relation to the E4X specification.


Contributing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a separate file CONTRIBUTING.md so we can take advantage of GitHub's UI? https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks for the feedback. Will do!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there's already a pending #114 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah yea I've been thinking of merge them into one ;)

------------

The main purpose of this repository is to continue evolving JSX. We are grateful to the community for contributing bugfixes and improvements.

### [Code of Conduct](https://code.fb.com/codeofconduct)

Meta has adopted a Code of Conduct that we expect project participants to adhere to. Please read [the full text](https://code.fb.com/codeofconduct) so that you can understand what actions will and will not be tolerated.

### Contribute Guide

Thank you for your interest in contributing to JSX. As JSX has being widely adopted and perceived as being stablized for years, the team has been convinced that it's not worth the churn for existing JSX users to take any non-trivial changes. Therefore, our current focus is to correctly document the existing semantics to align with the implementation reality, and spec out where implementations diverged to minimize inconsistencies of using JSX. Feature proposals are still welcome but they will only be considered as part of a larger and cohesive breaking changes such as JSX 2.0.


#### Contributing To The Spec

The JSX specification is written in [ecmarkup](https://github.com/tc39/ecmarkup), TC39's official tool for specifying syntax and semantics of ECMAScript and generating spec websites. You can find how to use it there.

We welcome both editorial and normative changes. However, normative changes may only be merged if a concensus can be reached from major implementations.


License
-------

Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2414,7 +2414,7 @@
</ul></div><div id="menu-toggle"><svg xmlns="http://www.w3.org/2000/svg" style="width:100%; height:100%; stroke:currentColor" viewBox="0 0 120 120">
<title>Menu</title>
<path stroke-width="10" stroke-linecap="round" d="M30,60 h60 M30,30 m0,5 h60 M30,90 m0,-5 h60"></path>
</svg></div><div id="menu-spacer"></div><div id="menu"><div id="menu-search"><input type="text" id="menu-search-box" placeholder="Search..."><div id="menu-search-results" class="inactive"></div></div><div id="menu-pins"><div class="menu-pane-header">Pins</div><ul id="menu-pins-list"></ul></div><div class="menu-pane-header">Table of Contents</div><div id="menu-toc"><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-intro" title="Introduction">Introduction</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-rationale" title="Rationale">Rationale</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-jsx" title="JSX Definition"><span class="secnum">1</span> JSX Definition</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-PrimaryExpression" title="Modified Productions"><span class="secnum">1.1</span> Modified Productions</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-elements" title="JSX Elements"><span class="secnum">1.2</span> JSX Elements</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-elements-early-errors" title="Static Semantics: Early Errors"><span class="secnum">1.2.1</span> SS: Early Errors</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-jsx-attributes" title="JSX Attributes"><span class="secnum">1.3</span> JSX Attributes</a></li><li><span class="item-toggle-none"></span><a href="#sec-jsx-children" title="JSX Children"><span class="secnum">1.4</span> JSX Children</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-string" title="JSX Strings"><span class="secnum">1.5</span> JSX Strings</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-string-characters" title="JSX String Characters"><span class="secnum">1.5.1</span> JSX String Characters</a></li><li><span class="item-toggle-none"></span><a href="#sec-HTMLCharacterReference" title="HTML Character References"><span class="secnum">1.5.2</span> HTML Character References</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-JSXString" title="JSX String Definition"><span class="secnum">1.5.3</span> JSX String Definition</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-JSXString-SV" title="Static Semantics: SV"><span class="secnum">1.5.3.1</span> SS: SV</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-why-not-template-literals" title="Why not Template Literals?"><span class="secnum">A</span> Why not Template Literals?</a></li><li><span class="item-toggle-none"></span><a href="#sec-why-not-JXON" title="Why not JXON?"><span class="secnum">B</span> Why not JXON?</a></li><li><span class="item-toggle-none"></span><a href="#sec-prior-art" title="Prior Art"><span class="secnum">C</span> Prior Art</a></li><li><span class="item-toggle-none"></span><a href="#sec-license" title="License"><span class="secnum">D</span> License</a></li></ol></div></div><div id="spec-container"><h1 class="version">Draft / March 4, 2022</h1><h1 class="title">JSX</h1>
</svg></div><div id="menu-spacer"></div><div id="menu"><div id="menu-search"><input type="text" id="menu-search-box" placeholder="Search..."><div id="menu-search-results" class="inactive"></div></div><div id="menu-pins"><div class="menu-pane-header">Pins</div><ul id="menu-pins-list"></ul></div><div class="menu-pane-header">Table of Contents</div><div id="menu-toc"><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-intro" title="Introduction">Introduction</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-rationale" title="Rationale">Rationale</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-jsx" title="JSX Definition"><span class="secnum">1</span> JSX Definition</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-PrimaryExpression" title="Modified Productions"><span class="secnum">1.1</span> Modified Productions</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-elements" title="JSX Elements"><span class="secnum">1.2</span> JSX Elements</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-elements-early-errors" title="Static Semantics: Early Errors"><span class="secnum">1.2.1</span> SS: Early Errors</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-jsx-attributes" title="JSX Attributes"><span class="secnum">1.3</span> JSX Attributes</a></li><li><span class="item-toggle-none"></span><a href="#sec-jsx-children" title="JSX Children"><span class="secnum">1.4</span> JSX Children</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-string" title="JSX Strings"><span class="secnum">1.5</span> JSX Strings</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-string-characters" title="JSX String Characters"><span class="secnum">1.5.1</span> JSX String Characters</a></li><li><span class="item-toggle-none"></span><a href="#sec-HTMLCharacterReference" title="HTML Character References"><span class="secnum">1.5.2</span> HTML Character References</a></li><li><span class="item-toggle">◢</span><a href="#sec-jsx-JSXString" title="JSX String Definition"><span class="secnum">1.5.3</span> JSX String Definition</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-jsx-JSXString-SV" title="Static Semantics: SV"><span class="secnum">1.5.3.1</span> SS: SV</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-why-not-template-literals" title="Why not Template Literals?"><span class="secnum">A</span> Why not Template Literals?</a></li><li><span class="item-toggle-none"></span><a href="#sec-why-not-JXON" title="Why not JXON?"><span class="secnum">B</span> Why not JXON?</a></li><li><span class="item-toggle-none"></span><a href="#sec-prior-art" title="Prior Art"><span class="secnum">C</span> Prior Art</a></li><li><span class="item-toggle-none"></span><a href="#sec-license" title="License"><span class="secnum">D</span> License</a></li></ol></div></div><div id="spec-container"><h1 class="version">Draft / March 8, 2022</h1><h1 class="title">JSX</h1>

<emu-intro id="sec-intro">
<h1>Introduction</h1>
Expand Down