-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground - Clear Format button fix #5849
Playground - Clear Format button fix #5849
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @ManuelOjedaWz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@ManuelOjedaWz Could you sign the CLA, rest looks good. |
@ivailop7 I've already signed the CLA but is not being detected here |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
These changes seem to have caused another bug, and it is now impossible to clear the formatting of multi-line text. |
Can you raise an issue, to have a look. |
This PR fixes an issue found in the Playground. When you select a portion of a selected text with the format applied, it could wrongly remove the format to another portion of the sentence with the same format applied.
Reference:
Screen.Recording.2024-04-08.at.11.07.17.mov