Skip to content

Commit

Permalink
Remove extraneous semicolon from mcrouter/lib/network/SecurityOptions…
Browse files Browse the repository at this point in the history
….cpp

Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631138

fbshipit-source-id: 48112271dbb3054b3f3d60f5b81b28753a154f1b
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 29, 2023
1 parent d855ebc commit 36197c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mcrouter/lib/network/SecurityOptions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const char* securityMechToString(SecurityMech mech) {
return "fizz";
case SecurityMech::KTLS12:
return "ktls12";
};
}
folly::assume_unreachable();
}

Expand Down

0 comments on commit 36197c5

Please sign in to comment.