Handle the case where transformSync returns null #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 85.68% 85.67% -0.02%
==========================================
Files 144 144
Lines 4556 4558 +2
Branches 712 713 +1
==========================================
+ Hits 3904 3905 +1
- Misses 582 583 +1
Partials 70 70
Continue to review full report at Codecov.
|
rafeca
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
rafeca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug when ignoring a file in the babel config: #255 (comment)
Test plan
Couldn't find any obvious tests that test this part of the code. Happy to add some tests if someone can point me in the right direction.