Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Fix failing tests #129

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix failing tests #129

merged 1 commit into from
Nov 30, 2017

Conversation

realityking
Copy link
Contributor

Failure seems to have been introduced with #68, before then tests are passing.

On that note, it would be great if CircleCI were set up for this repo. This cost me quite a bit of time today.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@realityking realityking mentioned this pull request Oct 21, 2017
Open
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@realityking realityking mentioned this pull request Oct 21, 2017
Closed
@realityking
Copy link
Contributor Author

Is prop-types still maintained? This PR has been open for an awfully long time.

@ljharb
Copy link
Contributor

ljharb commented Nov 30, 2017

ping @aweary

aweary
aweary approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@aweary aweary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm the only one maintaining it and I've been really busy lately 😬

I verified the tests fail locally on master and pass locally with these changes, LGTM thanks!

@aweary aweary merged commit 77c62a7 into facebook:master Nov 30, 2017
@realityking realityking deleted the fix-tests branch January 18, 2018 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aweary aweary aweary approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realityking @facebook-github-bot @ljharb @aweary