-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores(releases): rename script and add info note #3815
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# This will walk you through what version you are releasing | ||
./scripts/bump-oss-version.js --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN> | ||
yarn trigger-react-native-release --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn trigger-react-native-release --to-version 0.69.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN> | |
yarn trigger-react-native-release --to-version 0.y.0-rc.0 --token <YOUR_CIRCLE_CI_TOKEN> |
We use this format elsewhere, so we might as well can align here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the entire page is using 0.69 as the example version, so I'd rather keep it consistent across the page. Someone as a follow up PR (maybe in 6 months or so, to connect to your other comment) could do a pass on all the release pages and update them to change both the example code and remove "old versions" references. In quite a few pages we have things like "before 0.71" or even "before 0.68".
So maybe by the time 0.74 comes around (this Q4 or early next year) that would be a good time to give an overall pass to the whole section to remove old references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for now, but since 0.69 is out of support already, maybe we can remove this note in not-so-distant future?
@Simek this PR is ready to be merged - all the PRs that were pending are merged so now we need to merge this so that the docs are aligned. It's already approved by Meta (Alex) and current release crew (Marek) so all that's left is to get it in. I'm not sure if there's something I can do about the CircleCI error, it's totally unrelated. Do you want me to try and rebase the PR to see if that fixes it? |
This a follow up PR to update the docs to reflect a recent change in the release crew flow facebook/react-native#38666
This is currently in the process of getting aligned & backported across the release support window:
This PR needs to be merged AFTER all those PRs are merged.