Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSOD Memory Usage #20637

Closed
anthonyhumphreys opened this issue Aug 12, 2018 · 15 comments
Closed

RSOD Memory Usage #20637

anthonyhumphreys opened this issue Aug 12, 2018 · 15 comments
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@anthonyhumphreys
Copy link

anthonyhumphreys commented Aug 12, 2018

Environment

React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
      Memory: 11.73 GB / 32.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.7.0 - /usr/local/bin/node
      npm: 6.2.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
      Android SDK:
        Build Tools: 23.0.1, 25.0.0, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.1, 28.0.2
        API Levels: 23, 25, 26, 28
    IDEs:
      Android Studio: 3.1 AI-173.4819257
      Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.4.1 => 16.4.1
      react-native: 0.56.0 => 0.56.0
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7

Description

I will conduct more investigation to obtain some more solid info on this one, but so far I can only report high memory usage/leak when an RSOD is encountered in a RN project whilst Remote Debug was enabled - A RSOD occurred while my machine was unattended, on my return i found the attached usage (and a hot, loud MacBook! 😛) only affects iOS.

The project is a boilerplate I'm working on and is currently a testbed for some UX work - there are no debugging tools installed in it, only apollo-client and native-base. The same behaviour seems to occur in an independent project, and the error has been encountered on colleagues' machines.

screen shot 2018-08-12 at 15 13 57

Reproducible Demo

Have a component throw an error on render to trigger RSOD and leave for a while. Memory usage rapidly goes up. Seems to only happen when chrome debugger is attached.

More details to follow after investigating some more.

@stale
Copy link

stale bot commented Nov 10, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 10, 2018
@anthonyhumphreys
Copy link
Author

Hello,
Not got round to providing more issues but can confirm this behaviour does seem to still occur.

Reproduce - react native init -> throw an error in first render -> leave on RSOD and monitor resource usage

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 12, 2018
@hramos hramos removed the Bug Report label Feb 6, 2019
@kelset
Copy link
Contributor

kelset commented May 3, 2019

Hello there 👋 this issue seems to have been inactive for the past few weeks. Because of this, it's likely that the issue is not a high priority anymore or it has been solved by OP; for these reasons, we'll close it.

But please, if it's actually still an issue with 0.59 please comment below and we can reopen it or please send us a Pull Request with a fix 😊

@mikehardy
Copy link
Contributor

@kelset this is super old but I just experienced this and @Salakar mentioned it to me today as well. This is with react-native 0.59.9

reproduction is to run a react-native app in an iOS simulator, chuck an error that causes an RSOD / redbox / error screen then...wait. For me after just a couple hours I had about 30GB being used (!)

@anthonyhumphreys
Copy link
Author

anthonyhumphreys commented Jun 7, 2019 via email

@kelset
Copy link
Contributor

kelset commented Jun 10, 2019

Oh, interesting!

Thanks for the update, let's reopen this.

So this wasn't happening with 0.59.8? I can't really see any commits that I have cherrypicked for 0.59.9 that could be related to this: https://github.com/facebook/react-native/commits/0.59-stable

@kelset kelset reopened this Jun 10, 2019
@anthonyhumphreys
Copy link
Author

anthonyhumphreys commented Jun 10, 2019 via email

@kelset
Copy link
Contributor

kelset commented Jun 10, 2019

Oh ok - any chance you can do your testing against 0.60 rc too?

@anthonyhumphreys
Copy link
Author

anthonyhumphreys commented Jun 10, 2019 via email

@KingAmo
Copy link

KingAmo commented Jul 26, 2019

image
the same problem here, rn 0.59.10

@anthonyhumphreys
Copy link
Author

Hi @kelset i'm slowly putting together some tests in here: https://github.com/anthonyhumphreys/rsod-tests - should have a few more bits in there this evening. Apologies for the delay in getting this to you.

@stale
Copy link

stale bot commented Oct 27, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 27, 2019
@KingAmo
Copy link

KingAmo commented Oct 28, 2019

still has this issue in react native 0.61.2

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 28, 2019
@stale
Copy link

stale bot commented Jan 26, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jan 26, 2020
@stale
Copy link

stale bot commented Feb 2, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Feb 2, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants