-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSOD Memory Usage #20637
Comments
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
Hello, Reproduce - react native init -> throw an error in first render -> leave on RSOD and monitor resource usage |
Hello there 👋 this issue seems to have been inactive for the past few weeks. Because of this, it's likely that the issue is not a high priority anymore or it has been solved by OP; for these reasons, we'll close it. But please, if it's actually still an issue with 0.59 please comment below and we can reopen it or please send us a Pull Request with a fix 😊 |
@kelset this is super old but I just experienced this and @Salakar mentioned it to me today as well. This is with react-native 0.59.9 reproduction is to run a react-native app in an iOS simulator, chuck an error that causes an RSOD / redbox / error screen then...wait. For me after just a couple hours I had about 30GB being used (!) |
Yep same here. Those are the exact repro steps.
I’d send some dumps etc but my main machine is out of action at the moment
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mike Hardy <[email protected]>
Sent: Friday, June 7, 2019 9:17:15 PM
To: facebook/react-native
Cc: Humphreys, Anthony; Author
Subject: Re: [facebook/react-native] RSOD Memory Usage (#20637)
@kelset<https://github.com/kelset> this is super old but I just experienced this and @Salakar<https://github.com/Salakar> mentioned it to me today as well. This is with react-native 0.59.9
reproduction is to run a react-native app in an iOS simulator, chuck an error that causes an RSOD / redbox / error screen then...wait. For me after just a couple hours I had about 30GB being used (!)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#20637?email_source=notifications&email_token=ACP2QUTX2QOQA43EVGIMPQDPZK64XA5CNFSM4FPGHO62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXG4B5Q#issuecomment-500023542>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACP2QUXHKBNZG6QXZDFJER3PZK64XANCNFSM4FPGHO6Q>.
|
Oh, interesting! Thanks for the update, let's reopen this. So this wasn't happening with 0.59.8? I can't really see any commits that I have cherrypicked for 0.59.9 that could be related to this: https://github.com/facebook/react-native/commits/0.59-stable |
Not really sure! Will do some testing when I get a sec but I’m fairly sure it’s been an issue for a few versions now, think it’s just an evasive one.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Lorenzo Sciandra <[email protected]>
Sent: Monday, June 10, 2019 10:29:35 AM
To: facebook/react-native
Cc: Humphreys, Anthony; Author
Subject: Re: [facebook/react-native] RSOD Memory Usage (#20637)
Reopened #20637<#20637>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#20637?email_source=notifications&email_token=ACP2QUTK4DC6TL5CO7POSKLPZYNH7A5CNFSM4FPGHO62YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR4JXD3I#event-2400416237>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACP2QUQHLAMFNOM3FFEPM4LPZYNH7ANCNFSM4FPGHO6Q>.
|
Oh ok - any chance you can do your testing against 0.60 rc too? |
Sure thing
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Lorenzo Sciandra <[email protected]>
Sent: Monday, June 10, 2019 10:45:32 AM
To: facebook/react-native
Cc: Humphreys, Anthony; Author
Subject: Re: [facebook/react-native] RSOD Memory Usage (#20637)
Oh ok - any chance you can do your testing against 0.60 rc too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#20637?email_source=notifications&email_token=ACP2QUQURN6ZAWLHTNIBN63PZYPDZA5CNFSM4FPGHO62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXJNMJA#issuecomment-500356644>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACP2QUTDLQNGFAB7DEY55J3PZYPDZANCNFSM4FPGHO6Q>.
|
Hi @kelset i'm slowly putting together some tests in here: https://github.com/anthonyhumphreys/rsod-tests - should have a few more bits in there this evening. Apologies for the delay in getting this to you. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
still has this issue in |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
Environment
Description
I will conduct more investigation to obtain some more solid info on this one, but so far I can only report high memory usage/leak when an RSOD is encountered in a RN project whilst Remote Debug was enabled - A RSOD occurred while my machine was unattended, on my return i found the attached usage (and a hot, loud MacBook! 😛) only affects iOS.
The project is a boilerplate I'm working on and is currently a testbed for some UX work - there are no debugging tools installed in it, only apollo-client and native-base. The same behaviour seems to occur in an independent project, and the error has been encountered on colleagues' machines.
Reproducible Demo
Have a component throw an error on render to trigger RSOD and leave for a while. Memory usage rapidly goes up. Seems to only happen when chrome debugger is attached.
More details to follow after investigating some more.
The text was updated successfully, but these errors were encountered: