-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[META] add test case for template #23432
Labels
Contributor
A React Native contributor.
Partner
Resolution: Locked
This issue was locked by the bot.
🔩Test Infrastructure
Test infrastructure and continuous integration.
Comments
Related issue: #23893. |
@grabbou Is there a mechanism we can init a project from a local template. With this feature, we can test CI in current workflow to prevent bug and regressions. |
We already do it. Check ./scripts/test-manual-e2e.sh.
We always take default template from React Native version we init.
…On Fri, 15 Mar 2019 at 13:37, Jiawen Geng ***@***.***> wrote:
@grabbou <https://github.com/grabbou> Is there a mechanism we can init a
project from a local template. With this feature, we can test CI in current
workflow to prevent bug and regressions.
cc @dulmandakh <https://github.com/dulmandakh> @hramos
<https://github.com/hramos> @cpojer <https://github.com/cpojer>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23432 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxhldC_SJt7RPGurZXAIExhhyFtMcks5vW5QIgaJpZM4a5hxN>
.
|
I see, thanks. Maybe still can work with it in ci. I will see what I can do. |
We could definitely allow `--template` flag to accept path to a local
folder instead of an npm package name. Something to consider for the
future. CC: @Esemesek
…On Fri, 15 Mar 2019 at 14:07 Jiawen Geng ***@***.***> wrote:
I see, thanks. But it maybe a litter cumbersome since it requires run npm
pack first.
Maybe still can work with it in ci. I will see what I can do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23432 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWcxi3keSKbOTQi5iBMnO9alNdjx1VWks5vW5sqgaJpZM4a5hxN>
.
|
We have this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Contributor
A React Native contributor.
Partner
Resolution: Locked
This issue was locked by the bot.
🔩Test Infrastructure
Test infrastructure and continuous integration.
Test template is working in ci system. With this the when release new version should be more confident.
I may not have time for this recently, any pr is welcome.
The text was updated successfully, but these errors were encountered: