-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails on Xcode 14.3 RC #36635
Comments
I posted a workaround to the sample project: The underlying issue should probably be addressed in react-native directly, but I'm less familiar with patching those files directly. |
I couldn't get the workaround working because react-native-skia has issues when building the project |
Any updates?
@travis-mark temporary workaround fixes it. |
Thanks for confirming the workaround. I'll take a stab at patching react-native directly to fix the underlying, but it'll be a while as I'm currently busy and unfamiliar with Facebook's submission process. |
You are an absolute legend! Thank you |
@travis-mark Do we anything need to change in xcode to use the workaround Because, I get this after pod install in ios directory Ignoring ffi-1.15.5 because its extensions are not built. Try: gem pristine ffi --version 1.15.5 [!] Invalid |
Closing, please follow progress on the issue under #36739. |
It woks well, thanks for sharing it. Just a short question, should we change this workaround for next ios version? |
@travis-mark can you confirm, please? |
I'm stuck on this build failure issue for the past 3 days, Even after I tried some workaround still facing the issue. |
After applying the workaround from tavis-mark I had a very strange issue where the pods frameworks script would fail to copy the framework files when archiving a build (building worked fine). Turns out readlink would produce an invalid path and that's why it failed. I had to modify ios/Pods/Target Support Files/Pods-projectname/Pods-projectname-frameworks.sh and change if [ -L "${source}" ]; then
echo "Symlinked..."
source="$(readlink "${source}")"
fi to if [ -L "${source}" ]; then
echo "Symlinked..."
source="$(readlink -f "${source}")"
fi after that archiving worked again. |
No, you should not need xcode changes. min_ios_version_supported is defined in react-native. Can you post your complete Podfile? |
` platform :ios, '12.4' target 'app_name' do use_frameworks!config = use_native_modules! Flags change depending on the env values.flags = get_default_flags() pod 'Firebase', :modular_headers => true $RNFirebaseAsStaticFramework = truepermissions_path = '../node_modules/react-native-permissions/ios' pod 'Permission-Contacts', :path => "#{permissions_path}/Contacts" use_react_native!( target 'app_name' do post_install do |installer| |
@SulthanYS You don't have the workaround added to the file. |
Sorry, I thought you asking without the workaround to glance at the file. wait I'll share it |
@travis-mark , here it is ` platform :ios, min_ios_version_supported Force pods to match minimum iOS version for React NativeFixes build issue on Xcode Cloud where some podsUse iOS 12 calls despite being set as iOS 11def __apply_Xcode_14_3_RC_post_install_workaround(installer) target 'app_name' do use_frameworks!config = use_native_modules! Flags change depending on the env values.flags = get_default_flags() pod 'Firebase', :modular_headers => true $RNFirebaseAsStaticFramework = truepermissions_path = '../node_modules/react-native-permissions/ios' pod 'Permission-Contacts', :path => "#{permissions_path}/Contacts" use_react_native!( target 'app_nameTests' do post_install do |installer| ` |
It looks like min_ios_version_supported was defined in a relatively recent version of react-native. You might try updating react-native or adding
near the top of your Podfile. |
I did all the above changes,did pod install and yes it worked for me too. |
It's resolved here: Shopify/react-native-skia#1466 Update your package to the latest version |
Ok, this is how I "solved" it for now: The easier and fastest way to avoid this until the fix is not there is to downgrade the version of your XCode back to Ya'll can do this downloading it from here and moving to the applications folder. |
I've done as described here and it solved my issue |
There is an easy fix with CocoaPod. Inside your Podfile change the iOS Deployment Target for the specific package post_install do |installer|
react_native_post_install(
installer,
# Set `mac_catalyst_enabled` to `true` in order to apply patches
# necessary for Mac Catalyst builds
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
installer.pods_project.targets.each do |target|
if target.name == "React-Codegen"
target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.4'
end
end
end
end |
This is working for me. |
Just a quick note, if you're new. Make sure to reinstall pods.
|
Im having the same issue but Im not in a Mac. Im using Expo, so whenever I run Expo Start and run the react native app I get: `
Any clue? |
Add in PodFile.
run pod install |
Does this workaround is suitable for future Xcode updates? |
@alexvazquez Were you able to solve this? |
Fox expo user, just delete the iOS folder, and do a new build. |
ERROR VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead. None of these files exist:
None of these files exist:
|
I need help please I alway have this warning when I open one page of my app how can I fix it please even if the app works I don't understand this warning |
Is there a workaround for this using expo |
I am using expo but do not see iOS folder I currently build with eas, pleas help. |
@imraann0 what's your |
@Kudo I am using 47.0 |
@imraann0 please try to upgrade |
I have updated expo to 47.0.14, react-native to 0.70.8, deleted node_modules/, ran I run the expo cli on a Windows machine and connect to it with the Expo Go app v2.28.9 on my iPhone 14 Pro running iOS 16.4.1 (a) I'm still getting the error.. My package.json dependencies "dependencies": {
"@expo-google-fonts/open-sans": "^0.2.2",
"@expo/config-plugins": "^5.0.4",
"@expo/metro-config": "^0.5.2",
"@expo/vector-icons": "^13.0.0",
"@gorhom/bottom-sheet": "^4.4.5",
"@react-native-async-storage/async-storage": "~1.17.11",
"@react-native-community/datetimepicker": "6.5.2",
"@react-navigation/bottom-tabs": "^6.4.0",
"@react-navigation/core": "^6.4.0",
"@react-navigation/drawer": "^6.5.0",
"@react-navigation/material-top-tabs": "^6.3.0",
"@react-navigation/native": "^6.0.13",
"@react-navigation/stack": "^6.3.4",
"@sentry/react-native": "4.9.0",
"@tanstack/react-query": "^4.16.1",
"axios": "^0.21.1",
"axios-auth-refresh": "^3.3.4",
"buffer": "^6.0.3",
"color": "^4.2.3",
"csstype": "^3.1.1",
"date-fns": "^2.29.3",
"expo": "^47.0.14",
"expo-application": "~5.0.1",
"expo-auth-session": "~3.8.0",
"expo-build-properties": "^0.4.1",
"expo-camera": "~13.1.0",
"expo-cli": "^6.0.8",
"expo-constants": "~14.0.2",
"expo-dev-client": "~2.0.1",
"expo-device": "~5.0.0",
"expo-document-picker": "~11.0.1",
"expo-file-system": "~15.1.1",
"expo-firebase-analytics": "~8.0.0",
"expo-font": "~11.0.1",
"expo-google-app-auth": "~8.3.0",
"expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2",
"expo-linear-gradient": "~12.0.1",
"expo-linking": "~3.3.0",
"expo-local-authentication": "~13.0.2",
"expo-network": "~5.0.0",
"expo-notifications": "~0.17.0",
"expo-print": "~12.0.0",
"expo-random": "~13.0.0",
"expo-secure-store": "~12.0.0",
"expo-sharing": "~11.0.1",
"expo-splash-screen": "~0.17.5",
"expo-status-bar": "~1.4.2",
"expo-updates": "~0.15.6",
"expo-web-browser": "~12.0.0",
"js-base64": "^3.7.3",
"lottie-react-native": "5.1.4",
"mime": "^3.0.0",
"react": "18.1.0",
"react-dom": "18.1.0",
"react-hook-form": "^7.39.4",
"react-native": "0.70.8",
"react-native-alert-async": "^1.0.5",
"react-native-app-link": "^1.0.1",
"react-native-calendars": "^1.1264.0",
"react-native-dynamic-vector-icons": "^1.2.0",
"react-native-expo-image-cache": "^4.1.0",
"react-native-gesture-handler": "~2.8.0",
"react-native-google-drive-api-wrapper": "github:jaybuangan/react-native-google-drive-api-wrapper",
"react-native-in-app-notification": "^3.2.0",
"react-native-keyboard-aware-scroll-view": "^0.9.5",
"react-native-pager-view": "6.0.1",
"react-native-paper": "^4.12.5",
"react-native-reanimated": "~2.12.0",
"react-native-redash": "^16.1.1",
"react-native-render-html": "^6.3.4",
"react-native-safe-area-context": "4.4.1",
"react-native-screens": "~3.18.0",
"react-native-svg": "13.4.0",
"react-native-svg-transformer": "^1.0.0",
"react-native-tab-view": "^3.3.0",
"react-native-use-persist-storage": "^1.0.2",
"react-native-view-shot": "3.4.0",
"react-native-webview": "11.23.1",
"react-navigation-collapsible": "^5.10.2",
"rrule": "^2.7.1",
"sentry-expo": "~6.0.0"
},
"devDependencies": {
"@babel/core": "^7.20.2",
"@babel/plugin-proposal-numeric-separator": "^7.18.6",
"@react-native-community/eslint-config": "3.2.0",
"@types/accounting": "^0.4.2",
"@types/color": "^3.0.2",
"@types/lodash": "^4.14.171",
"@types/mime": "^3.0.1",
"@types/react": "~18.0.24",
"@types/react-native": "~0.70.6",
"@types/react-native-app-link": "^1.0.0",
"@types/react-native-calendars": "^1.505.4",
"@types/react-native-vector-icons": "^6.4.13",
"babel-eslint": "^10.1.0",
"babel-plugin-inline-dotenv": "^1.7.0",
"babel-plugin-module-resolver": "^4.1.0",
"babel-preset-expo": "~9.2.2",
"eslint": "^8.28.0",
"eslint-config-prettier": "^8.5.0",
"eslint-config-universe": "^11.1.1",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-import-helpers": "^1.3.1",
"eslint-plugin-jsx-a11y": "^6.6.1",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.31.11",
"jest-expo": "^47.0.1",
"prettier": "^2.7.1",
"typescript": "^4.9.3"
}, I'd appreciate any advice, thanks. |
Me too... Do you it achieved the fix? |
@Santosl2 I ended up just updating to Expo v48. I guess there's a fix in one of the versions in between but not sure which. If you're unable to move to 48, perhaps you could try the last version of Expo 47. |
Thx dude! Works fine now |
We were using react-native@69.* and only updating to 69.9 did not fix the issue. The only fix that helped was adding
|
Description
Xcode Cloud now offers and appears to auto-select Xcode 14.3 Release Candidate for builds. This trips an iOS versioning bug. This is the relevant error section:
So, the error is that react-native's minimum version is iOS 12.4 but many pods are getting set to 11.0. The surface answer is to patch the projects, but the underlying problem is
get_react_codegen_spec
uses a hardcoded '11.0' rather than '12.4' ormin_ios_version_supported
defined in react_native_pods.rb.React Native Version
0.71.4
Output of
npx react-native info
NOTE: This is from my local machine. I am working on getting
npx react-native info
output from the build machine on Xcode Cloud.info Fetching system and libraries information...
System:
OS: macOS 13.2.1
CPU: (10) arm64 Apple M1 Max
Memory: 707.53 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 19.5.0 - /opt/homebrew/bin/node
Yarn: Not Found
npm: 9.3.1 - /opt/homebrew/bin/npm
Watchman: 2023.02.20.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9477386
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 19.0.2 - /opt/homebrew/opt/openjdk/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: ^0.71.4 => 0.71.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Create a sample project and connect to Xcode Cloud in App Store Connect. Run workflow on Xcode 14.3 RC.
Snack, code example, screenshot, or link to a repository
https://github.com/travis-mark/lrn
The text was updated successfully, but these errors were encountered: