[docs] Deprecate MapView in favor of airbnb/react-native-maps

[mkonicek]

Compared to the <MapView> that comes with React Native, react-native-maps work on Android and is more feature complete. It is actively maintained and used extensively (9.2k installs / month, see JS.Coach).

We think now is a good time to switch to react-native-maps in your applications and make react-native-maps the official <MapView> implementation for React Native.

We are going to release the deprecated <MapView> as a separate npm module so you can migrate to react-native-maps at your own pace.

Test Plan

Checked the docs render correctly on the website:

cd website
npm install
npm start

Warning is shown:

Published the module separately (https://github.com/facebookarchive/react-native-deprecated-modules, will also publish to npm in January) so people can continue using it and migrate to Airbnb maps at their own pace. Linked the module to a sample app using react-native link, it works 🎉

import MapView from 'deprecated-react-native-ios-mapview';

export default class MapsTest extends Component {
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>
          Welcome to React Native!
        </Text>
        <MapView
          style={{width: 200, height: 200, margin: 40}}
          showsUserLocation={true}
          onRegionChangeComplete={(region) => {alert(region.longitude)}}
        />
...

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @caabernathy and @spikebrehm to be potential reviewers.

[spikebrehm]

Exciting!

[lacker]

How about making it so that if you use this class, a warning gets logged?

[lacker]

What do people have to do to make this warning go away - just npm install deprecated-react-native-ios-mapview and add the appropriate import? Also, let's not refer to it as "Airbnb maps" any more than we refer to the existing one as "Facebook maps" - let's just call it "the react-native-maps module".

[mkonicek]

What do people have to do to make this warning go away - just npm install deprecated-react-native-ios-mapview and add the appropriate import?

Yes that will work, but probably only at version >= 0.42 where we remove the native code. If people install deprecated-react-native-ios-mapview (and react-native link it) they'd have the Obj-C code twice, until we remove it in v0.42. Let me check how that works but seems strange.

Ideally people would migrate to react-native-maps to make the warning go away. But I see your point the warning can be annoying and you'd just like to make it go away. We have other deprecation warnings like this in the codebase though - maybe their point is to always be visible until you fix the code?

[mkonicek]

Updated the warning message 👍

[lacker]

Looks good. Not sure if the travis error is spurious - I'll try rebuilding. Once CI is clear let's shipit.

[mkonicek]

@facebook-github-bot import

[facebook-github-bot]

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[mkonicek]

@lacker Sandcastle confirms this breaks some screenshot tests (probably by showing the warning :)). I'll fix that.

[mkonicek]

@lacker Should be good to go now, tests passed.

[lacker]

@facebook-github-bot shipit