[NavigationTransitioner] Fix animation in fast navigation between scenes

[gitim]

There is a bug in navigation animation:

navigation animation from route-2 was awful, route-3 scene appeared without any animation, I pushed above example to gitim@46dd8c9.

This bug can be reproduced when user navigates to the next scene immediately after navigation to the current one or when navigating between scenes programmatically (e.g. between loading scene and whatever next scene). I made some investigation and It looks like that progress should be reseted before building the new _transitionProps.

The above example after applying this patch:

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @hedgerwang and @ericvicenti to be potential reviewers.

[ericvicenti]

Thanks for looking into this! Could you possibly post a gist of a sample app that demonstrates this issue? I'd like to look into this further because I'm slightly surprised that this fixes the problem.

[gitim]

Yes, sure. I created a separate app https://github.com/gitim/NavigationExperimentalAnimation, it is almost the same as an example from UIExplorer.

[gitim]

Hmm, it is strange, not adding progress to animations (https://github.com/facebook/react-native/blob/master/Libraries/NavigationExperimental/NavigationTransitioner.js#L147-153) also fixes an animation, I just tried to remove these lines and the animation plays fine. Can't figure out how they related, @ericvicenti any idea?

[ericvicenti]

cc @janicduplessis, I think this might be a race condition with animated values.

Has this changed in recent versions of RN, or has the issue always been there?

[janicduplessis]

Is it using native animations? There are some race conditions that can happen on iOS, you can test out #10663 if it's the case.

[gitim]

@ericvicenti I noticed this in 0.31 I think, when NavigationAnimatedView was removed, and I had to transition to NavigationTransitioner.

[gitim]

@janicduplessis @ericvicenti I checked this with patch from #10663, it doesn't fix the animation.

upd: @janicduplessis it is not using native animations

[ericvicenti]

Ok, seems like this is a minor issue that has been here for a while. The fix makes sense

@facebook-github-bot shipit

[facebook-github-bot]

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

[mkonicek]

@facebook-github-bot shipit

[facebook-github-bot]

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.