Dispatch native handled events to JS #10981
Conversation
Dispatch native handled events to JS on Android
|
By analyzing the blame information on this pull request, we identified @ide and @ryangomba to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Great, LGTM |
|
Separately, @janicduplessis I think we shouldn't rate limit native events - e.g.. ignore scrollEventThrottle when dispatching native event calls, but respect it when calling across the bridge. |
|
It would be nice to do so but it will require changing quite a bit since at the moment we are hooking up to the JS event dispatcher to intercept native events so they are already throttled at this point, I think the best solution would be to have a generic way to throttle events inside the dispatcher instead of the adhoc implementation in ScrollView and have native animated events ignore that. |
|
Could sending events to JS that were handled break anything? |
|
@mkonicek It does not since native animated event won't do anything when it receives the event in JS. The issue happens because some components like ScrollView for example do some JS logic so they expect to still receive those events even when there is an animated event attached. |
|
lgtm |
|
@astreet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: When native events where handled they were not sent to JS as an optimization but this caused some issues. One of the major one is touches are not handled properly inside a ScrollView with an Animated.event because it doesn't receive scroll events so it can't cancel the touch if the user scrolled. Closes facebook#10981 Differential Revision: D4226403 Pulled By: astreet fbshipit-source-id: 41278d3ed4b684af142d9e273b11b974eb679879
When native events where handled they were not sent to JS as an optimization but this caused some issues. One of the major one is touches are not handled properly inside a ScrollView with an Animated.event because it doesn't receive scroll events so it can't cancel the touch if the user scrolled.