Fix packager asset requests on windows #11254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @cpojer and @davidaurelio to be potential reviewers. |
janicduplessis
force-pushed
the
fix-assets-windows
branch
from
b285c2d to
37ea8d8
Compare
cpojer
approved these changes
Dec 1, 2016
|
Thanks @janicduplessis for being on top of things. |
facebook-github-bot
added
CLA Signed
|
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
robclouth
pushed a commit
to robclouth/react-native
that referenced
this pull request
Dec 7, 2016
Summary: 6554ad5 broke assets on windows, this fixes it and add a test to avoid regressions. Ideally we'd run all the Dependency graph tests on both posix and win32 filesystems but that would probably require doing some sort of factory function to create the tests because I don't think we want to duplicate every test (file is big enough already :)). So for now I just copied that one test and changed the paths manually. **Test plan** Run the new test without the fix -> fails Run the new test with the fix -> succeeds Closes facebook#11254 Differential Revision: D4265157 Pulled By: cpojer fbshipit-source-id: 511470276bd950c2943e94c2dce6840df0fe6d69
mkonicek
pushed a commit
that referenced
this pull request
Dec 12, 2016
Summary: 6554ad5 broke assets on windows, this fixes it and add a test to avoid regressions. Ideally we'd run all the Dependency graph tests on both posix and win32 filesystems but that would probably require doing some sort of factory function to create the tests because I don't think we want to duplicate every test (file is big enough already :)). So for now I just copied that one test and changed the paths manually. **Test plan** Run the new test without the fix -> fails Run the new test with the fix -> succeeds Closes #11254 Differential Revision: D4265157 Pulled By: cpojer fbshipit-source-id: 511470276bd950c2943e94c2dce6840df0fe6d69
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: 6554ad5 broke assets on windows, this fixes it and add a test to avoid regressions. Ideally we'd run all the Dependency graph tests on both posix and win32 filesystems but that would probably require doing some sort of factory function to create the tests because I don't think we want to duplicate every test (file is big enough already :)). So for now I just copied that one test and changed the paths manually. **Test plan** Run the new test without the fix -> fails Run the new test with the fix -> succeeds Closes facebook#11254 Differential Revision: D4265157 Pulled By: cpojer fbshipit-source-id: 511470276bd950c2943e94c2dce6840df0fe6d69
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: 6554ad5983ae85212684a09869e2ea2e0b743dd3 broke assets on windows, this fixes it and add a test to avoid regressions. Ideally we'd run all the Dependency graph tests on both posix and win32 filesystems but that would probably require doing some sort of factory function to create the tests because I don't think we want to duplicate every test (file is big enough already :)). So for now I just copied that one test and changed the paths manually. **Test plan** Run the new test without the fix -> fails Run the new test with the fix -> succeeds Closes facebook/react-native#11254 Differential Revision: D4265157 Pulled By: cpojer fbshipit-source-id: 511470276bd950c2943e94c2dce6840df0fe6d69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6554ad5 broke assets on windows, this fixes it and add a test to avoid regressions.
Ideally we'd run all the Dependency graph tests on both posix and win32 filesystems but that would probably require doing some sort of factory function to create the tests because I don't think we want to duplicate every test (file is big enough already :)). So for now I just copied that one test and changed the paths manually.
Test plan
Run the new test without the fix -> fails
Run the new test with the fix -> succeeds