[jest] Added mocked functions to StatusBarManager #11322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Nice work! |
robclouth
pushed a commit
to robclouth/react-native
that referenced
this pull request
Dec 7, 2016
Summary: **Description:** Jest tests that use that StatusBar failing because the status bar functions aren't mocked. Errors I ran into: `TypeError: StatusBarManager. setNetworkActivityIndicatorVisible is not a function` `TypeError: StatusBarManager. setHidden is not a function` `TypeError: StatusBarManager. setStyle is not a function` **Fix:** Added mocks for all the functions that the StatusBar offers according to the docs: https://facebook.github.io/react-native/docs/statusbar.html **Test plan (required)** Verify that the tests using StatusBar and its functions succeed. Closes facebook#11322 Differential Revision: D4284536 Pulled By: cpojer fbshipit-source-id: b67be8c0595d91ee9aca4784f457c0959d7e45d5
mkonicek
pushed a commit
that referenced
this pull request
Dec 12, 2016
Summary: **Description:** Jest tests that use that StatusBar failing because the status bar functions aren't mocked. Errors I ran into: `TypeError: StatusBarManager. setNetworkActivityIndicatorVisible is not a function` `TypeError: StatusBarManager. setHidden is not a function` `TypeError: StatusBarManager. setStyle is not a function` **Fix:** Added mocks for all the functions that the StatusBar offers according to the docs: https://facebook.github.io/react-native/docs/statusbar.html **Test plan (required)** Verify that the tests using StatusBar and its functions succeed. Closes #11322 Differential Revision: D4284536 Pulled By: cpojer fbshipit-source-id: b67be8c0595d91ee9aca4784f457c0959d7e45d5
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: **Description:** Jest tests that use that StatusBar failing because the status bar functions aren't mocked. Errors I ran into: `TypeError: StatusBarManager. setNetworkActivityIndicatorVisible is not a function` `TypeError: StatusBarManager. setHidden is not a function` `TypeError: StatusBarManager. setStyle is not a function` **Fix:** Added mocks for all the functions that the StatusBar offers according to the docs: https://facebook.github.io/react-native/docs/statusbar.html **Test plan (required)** Verify that the tests using StatusBar and its functions succeed. Closes facebook#11322 Differential Revision: D4284536 Pulled By: cpojer fbshipit-source-id: b67be8c0595d91ee9aca4784f457c0959d7e45d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Jest tests that use that StatusBar failing because the status bar functions aren't mocked.
Errors I ran into:
TypeError: StatusBarManager. setNetworkActivityIndicatorVisible is not a functionTypeError: StatusBarManager. setHidden is not a functionTypeError: StatusBarManager. setStyle is not a functionFix:
Added mocks for all the functions that the StatusBar offers according to the docs: https://facebook.github.io/react-native/docs/statusbar.html
Test plan (required)
Verify that the tests using StatusBar and its functions succeed.