more accurate product-name regex

[TomSwift]

Some projects define multiple targets, including app extensions, which are built with a “.appex” extension. This fix prevents the buildProject method from selecting any app extension (e.g. a Today.appex today-widget extension) as the product name.

Thanks for submitting a PR! Please read these instructions carefully:

• Explain the motivation for making this change.
• Provide a test plan demonstrating that the code is solid.
• Match the code formatting of the rest of the codebase.
• Target the master branch, NOT a "stable" branch.

Motivation (required)

When building our workspace, ReactNative was failing to install the app to the simulator because it calculated an incorrect path to the app itself. It was attempting to install "Today.app" when it should have been installing "Remitly.app". I discovered that ReactNative parses the build output to identify the generated app name, and that this was broken when the build also generated an app extension. The fix was to tighten the regex to not select any target that produces a ".appex" filename.

My build output outputs the following:

...
export FULL_PRODUCT_NAME=Today.appex
...

and then later:

...
export FULL_PRODUCT_NAME=Remitly.app
...

ReactNative was choosing the first FULL_PRODUCT_NAME=Today.appex. My change forces it to find a product that actually generates a ".app" (vs. ".appex").

Test Plan (required)

The command I ran:

react-native run-ios --scheme Debug

Here is the tail of the output prior to the fix. Note that the app name is incorrect - "Today.app". "Today" is the name of the Today app extension which is built as part of the product, but is not in-fact the app itself:

** BUILD SUCCEEDED **


Installing build/Build/Products/Debug-iphonesimulator/Today.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Print: Entry, ":CFBundleIdentifier", Does Not Exist

Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/Today.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist


error Command failed with exit code 1.

Here is the tail of the output after the fix. Note that the app name is now correct - "Remitly.app".

** BUILD SUCCEEDED **


Installing build/Build/Products/Debug-iphonesimulator/Remitly.app
Launching internal.remitly.remitly
internal.remitly.remitly: 98666
✨  Done in 25.77s.

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

[janicduplessis]

Thanks for the detailed PR! Looks good.

@facebook-github-bot shipit

[facebook-github-bot]

@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[BenjaminG]

Hi guys, looks like this commit created exactly the opposite behaviour on my project: the modified regex just doesn't find the FULL_PRODUCT_NAME string in the build output anymore...
It seems the issue comes from the $ at the end of the regex.

[BrendonSled]

We are also seeing a similar issue with this PR. It has broke our scheme builds.

BUILD_IOS, productNameMatch: export FULL_PRODUCT_NAME=xxxxxxx.app,xxxxxxx
BUILD_IOS, resolving with: xxxxxxx
Installing build/Build/Products/Debug-iphonesimulator/xxxxxxx.app
Launching org.reactjs.native.example.xxxxxxx
org.reactjs.native.example.xxxxxxx: 6002

[TomSwift]

@BenjaminG @BrendonSled what is your project's FULL_PRODUCT_NAME, in particular the extension? The regex should match any with ".app" at the end of the value. Previously it would match against ".appex" extensions, which I believe to never be desirable.

[BrendonSled]

Our was xx.app the issue was the scheme was also being appended to the name.
It's outputted as xx.app,schemeName