Add missing mock for AppState (removeEventListener) #17908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** In the same vein as #11199, this finish the mock for the native module `AppState`. **Test plan** Create a component that uses `AppState`, e.g. ```jsx import React, { Component } from 'react'; import { AppState } from 'react-native'; class TestComponent extends Component { componentDidMount() { AppState.addEventListener('change', this.stateChangeListener); } componentWillUnmount() { AppState.removeEventListener('change', this.stateChangeListener); } } ``` Reference: https://facebook.github.io/react-native/docs/appstate.html#removeeventlistener
facebook-github-bot
added
CLA Signed
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
|
Something went wrong executing that command, @mkonicek could you take a look? |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I am testing with Jest a component that use AppState.removeEventListener and I am currently facing a fatal error saying that
AppState.removeEventListenerisundefined.Test Plan
Create a component that uses
AppState, e.g.It should pass test using Jest (snapshots)
Related PRs
It's the continuation of #11199. This PR finish the mock for the native module
AppState.Release Notes
[ GENERAL ] [ BUGFIX ] [AppState] Add missing mock for Jest for
removeEventListenermethod.