-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onInsetsChange property to SafeAreaView #19627
Closed
clmntcrl
wants to merge
24
commits into
facebook:master
from
clmntcrl:components-safeareaview-oninsetschange
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2e75e28
Add onInsetsChange prop to SafeAreaView
clmntcrl 982f893
Remove @providesModule
clmntcrl 26a8d5c
Fix issues to pass Flow tests
clmntcrl 1a557b7
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl d957014
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 58dc07a
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 70c6055
Add onInsetsChange prop to SafeAreaView
clmntcrl 758ae93
Remove @providesModule
clmntcrl 59faec2
Fix issues to pass Flow tests
clmntcrl 0d26336
Merge branch 'components-safeareaview-oninsetschange' of https://gith…
clmntcrl 5dc2ff9
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 35cbf1b
Merge branch 'components-safeareaview-oninsetschange' of https://gith…
clmntcrl c2d4cb6
Fix `children` is missing in props flow test error
clmntcrl 48e697c
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl ca61a6b
A better children PropType
clmntcrl d956812
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 1a93364
Better Flow type for onInsetsChange
clmntcrl dc366ed
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 3f9412a
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl f0e872b
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl b07d007
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 97de2f6
Merge branch 'master' into components-safeareaview-oninsetschange
clmntcrl 485286a
Merge branch 'master' into components-safeareaview-oninsetschange
hramos c9b52f7
Update SafeAreaViewExample.js
hramos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are destructuring the props here and then not doing anything with
onInsetsChange
. Do you mind patching up the code to make it work properly and making sure the test plan and example show that this is working properly?