Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YellowBox in 0.62 #28457

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

rickhanlonii
Copy link
Member

Summary

This diff fixes #28454, which is a regression to yellowbox specific to 0.62 where the Flipper network inspector causes YellowBox to crash the app due to using base64 images.

The fix is to convert these images to files.

Changelog

[Fix] [General] - Fix YellowBox crashing

Test Plan

Chevrons

Screen Shot 2020-03-30 at 8 25 49 PM

Failed icon

Screen Shot 2020-03-30 at 8 18 23 PM

Loading icon

Screen Shot 2020-03-30 at 8 18 17 PM

Complete (removed icon)

Screen Shot 2020-03-30 at 8 17 55 PM

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Mar 31, 2020
@rickhanlonii rickhanlonii requested a review from hramos March 31, 2020 00:35
@rickhanlonii rickhanlonii changed the title Fix yellowbox in 0.62 Fix YellowBox in 0.62 Mar 31, 2020
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 87759d0

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cpojer cpojer merged commit 227aa96 into facebook:0.62-stable Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants