Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNTester UI Redesign #29685

Closed
wants to merge 4 commits into from
Closed

RNTester UI Redesign #29685

wants to merge 4 commits into from

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Aug 18, 2020

Summary

This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.

Changelog

This list is not exhaustive.

  • The initial App screen is redesigned.

    • A bottom Navbar has been added.
    • Filter pills are added.
    • The list card UI is updated.

  • The example page UI is updated.

  • Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.

  • Bookmarking functionality is added.

  • The documentation URL is added to the example page.

  • RNTester doesn't lose its state on a hard refresh (even on iOS).

Screenshots

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2020
@anku255
Copy link
Contributor Author

anku255 commented Aug 18, 2020

@rickhanlonii This PR is stacked on top of #29567. The changed files should be updated once #29567 gets landed.

@pull-bot
Copy link

pull-bot commented Aug 18, 2020 •
edited
Loading

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 2dceadd

@sansyrox
Copy link
Contributor

Here is the iOS Demo:

https://drive.google.com/file/d/1po_RfluZ_FYTQShPJq6WLZW8urid08V6/view?usp=sharing

@YashKumarVerma
Copy link
Contributor

YashKumarVerma commented Aug 18, 2020 •
edited
Loading

The Android Demo is here direct link

Google Drive Link

@anku255 @manyaagarwal
@chirag-singhal @AnshG714 @YashKumarVerma @sansyrox @anikethsaha @Xtremilicious @jevakallio @rickhanlonii
Add UI changes
f46eb39 
Co-authored-by: agarwalmanya <[email protected]>
Co-authored-by: chirag-singhal <[email protected]>
Co-authored-by: Ansh Godha <[email protected]>
Co-authored-by: Yash Kumar Verma <[email protected]>
Co-authored-by: Sanskar Jethi <[email protected]>
Co-authored-by: Aniketh Saha <[email protected]>
Co-authored-by: Xtremilicious <[email protected]>
Co-authored-by: Jani Evakallio <[email protected]>
@anku255 anku255 changed the base branch from master to 0.63-stable August 20, 2020 05:15
@anku255 anku255 changed the base branch from 0.63-stable to master August 20, 2020 05:16
facebook-github-bot
facebook-github-bot reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Aug 20, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1271462

chirag-singhal and others added 3 commits August 20, 2020 17:37
@chirag-singhal @anku255
Add UI fixes
0a6aa59 
* Add documentation URL to examples and remove community screen

* Navbar UI Changes,

* Add filter category to each example

* Fix docs icons and add empty state
@anku255
Fix flow errors
f3f59b7
@anku255
Fix lint issues
2dceadd
facebook-github-bot
facebook-github-bot reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @anku255 in 549e5a8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 26, 2020
@rickhanlonii rickhanlonii deleted the mlh-fellowship branch August 26, 2020 15:35
bigfootjon pushed a commit that referenced this pull request Aug 26, 2020
@anku255 @manyaagarwal
@chirag-singhal @AnshG714 @YashKumarVerma @sansyrox @anikethsaha @Xtremilicious @jevakallio @bigfootjon
RNTester UI Redesign (#29685)
1270873 
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.

This list is not exhaustive.

- The initial App screen is redesigned.
  - A bottom Navbar has been added.
   - Filter pills are added.
   - The list card UI is updated.

- The example page UI is updated.

- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.

- Bookmarking functionality is added.

- The documentation URL is added to the example page.

- RNTester doesn't lose its state on a hard refresh (even on iOS).

<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png" />

Pull Request resolved: #29685

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

{F302717939}

Note: this failed **before** this diff too:

{F302745716}

Reviewed By: mdvacca, cpojer

Differential Revision: D23240434

fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2

Co-authored-by: agarwalmanya <[email protected]>
Co-authored-by: chirag-singhal <[email protected]>
Co-authored-by: Ansh Godha <[email protected]>
Co-authored-by: Yash Kumar Verma <[email protected]>
Co-authored-by: Sanskar Jethi <[email protected]>
Co-authored-by: Aniketh Saha <[email protected]>
Co-authored-by: Xtremilicious <[email protected]>
Co-authored-by: Jani Evakallio <[email protected]>
This was referenced Oct 25, 2020
Closed
Closed
philippeauriach pushed a commit to philippeauriach/react-native that referenced this pull request May 5, 2021
@anku255 @manyaagarwal
@chirag-singhal @AnshG714 @YashKumarVerma @sansyrox @anikethsaha @Xtremilicious @jevakallio @philippeauriach
RNTester UI Redesign (facebook#29685)
b2ef794 
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.

This list is not exhaustive.

- The initial App screen is redesigned.
  - A bottom Navbar has been added.
   - Filter pills are added.
   - The list card UI is updated.

- The example page UI is updated.

- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.

- Bookmarking functionality is added.

- The documentation URL is added to the example page.

- RNTester doesn't lose its state on a hard refresh (even on iOS).

<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png" />

Pull Request resolved: facebook#29685

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

{F302717939}

Note: this failed **before** this diff too:

{F302745716}

Reviewed By: mdvacca, cpojer

Differential Revision: D23240434

fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2

Co-authored-by: agarwalmanya <[email protected]>
Co-authored-by: chirag-singhal <[email protected]>
Co-authored-by: Ansh Godha <[email protected]>
Co-authored-by: Yash Kumar Verma <[email protected]>
Co-authored-by: Sanskar Jethi <[email protected]>
Co-authored-by: Aniketh Saha <[email protected]>
Co-authored-by: Xtremilicious <[email protected]>
Co-authored-by: Jani Evakallio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@cpojer cpojer Awaiting requested review from cpojer

@hramos hramos Awaiting requested review from hramos

@mhorowitz mhorowitz Awaiting requested review from mhorowitz

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anku255 @pull-bot @sansyrox @YashKumarVerma @analysis-bot @react-native-bot @facebook-github-bot @chirag-singhal