@react-native/tester should be private
#34570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: bfb36c2 |
Base commit: bfb36c2 |
|
@tido64 can you rebase this as the CI should be green now? |
tido64
force-pushed
the
tido/rename-rn-tester-package-name
branch
from
55ee849 to
dcc7bb9
Compare
cortinico
requested changes
Sep 14, 2022
packages/rn-tester/package.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "@react-native/tester", | |||
| "private": true, | |||
| "name": "@react-native/rn-tester", | |||
There was a problem hiding this comment.
Hey @tido64,
Can I ask you to undo the renaming?
We had some discussions internally about this specific package (RN Tester) and it turns out that the status quo is the preferred way.
@react-native/testeris the correct name of this package as it's the "React Native Tester"packages/rn-testerwe're going to keep the folder name as it has better discoverability + we're depriotizing the folder rename (as it brings little value at the moment and it slow us down drastically).
More on this here: #34692
The other changes are valid
tido64
changed the title
@react-native/tester should be private
cortinico
approved these changes
Sep 15, 2022
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @tido64 in 49c90f7. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Made `react-native/tester` private. ## Changelog [Internal] [Fixed] - Made `react-native/tester` private Pull Request resolved: facebook#34570 Test Plan: n/a Reviewed By: lunaleaps Differential Revision: D39235797 Pulled By: cortinico fbshipit-source-id: d5dee20f1ddfc198b3a776464a91de470ce824f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made
@react-native/testerprivate.Changelog
[Internal] [Fixed] - Made
@react-native/testerprivateTest Plan
n/a