Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>. #34576

Closed
wants to merge 5 commits into from

Conversation

gedeagas
Copy link
Contributor

@gedeagas gedeagas commented Sep 2, 2022

Summary

This PR aims to add support for objectFit a partial equivalent to the resizeMode style and prop of Image.

Changelog

[General] [Added] - Add support for objectFit style of Image.

Test Plan

  1. Open the RNTester app and navigate to the Image page
  2. See the Object Fit section.

Screenshot_1662112702

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022
@gedeagas
Copy link
Contributor Author

gedeagas commented Sep 2, 2022

Task Umbrella
#34425

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022
@gedeagas gedeagas changed the title feat(objectFit): Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>. feat: Adding support for objectFit a partial equivalent to the resizeMode style and prop of <Image>. Sep 2, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 2, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 2, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,637,129 +489
android hermes armeabi-v7a 7,049,127 +494
android hermes x86 7,939,086 +479
android hermes x86_64 7,911,113 +473
android jsc arm64-v8a 9,513,217 +290
android jsc armeabi-v7a 8,288,514 +292
android jsc x86 9,452,752 +269
android jsc x86_64 10,044,007 +289

Base commit: 12e5842
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 2, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 12e5842
Branch: main

@gedeagas
Copy link
Contributor Author

gedeagas commented Sep 5, 2022

Resolved, please re review @necolas

@gedeagas gedeagas requested a review from necolas September 5, 2022 03:30
@gedeagas
Copy link
Contributor Author

gedeagas commented Sep 5, 2022

Hi @necolas seems that this PR #34585 is already imported to phabricator thus makes this PR obsolete (?). Should i close this?

@necolas
Copy link
Contributor

necolas commented Sep 5, 2022

No, this is the first PR and the one we focused on. Close the other one

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @gedeagas in b2452ab.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 8, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…Mode style and prop of <Image>. (facebook#34576)

Summary:
This PR aims to add support for objectFit a partial equivalent to the resizeMode style and prop of Image.

## Changelog

[General] [Added] - Add support for objectFit style of Image.

Pull Request resolved: facebook#34576

Test Plan:
1. Open the RNTester app and navigate to the Image page
2. See the Object Fit section.

![Screenshot_1662112702](https://user-images.githubusercontent.com/8868908/188115315-5d5aa971-93ba-4437-a54b-c5ea69b00c08.png)

Reviewed By: rickhanlonii

Differential Revision: D39261176

Pulled By: jacdebug

fbshipit-source-id: 1eefd76b6c11ed5fc52b2c524ad78c91051077f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs TypeScript Update Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants