file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… #34835

rahul3002 · 2022-10-01T12:08:32Z

…ugin

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

github-actions · 2022-10-01T12:09:37Z

	Fails
🚫	📋 Verify Changelog Format - A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 6a04922

cortinico

Thanks for sendign this @rahul3002
I noticed you used the wrong string react-native/gradle-plugin.
It should be instead @react-native/gradle-plugin

Please update all the occurencies

cortinico · 2022-10-03T11:15:19Z

.circleci/verdaccio.yml

+  'react-native/gradle-plugin.':
    access: $all
    publish: $all


You can remove this block entirely

cortinico · 2022-10-03T11:15:30Z

.gitignore

@@ -24,7 +24,7 @@ project.xcworkspace

 # Gradle
 /build/
-/packages/react-native-gradle-plugin/build/
+/packages/react-native/gradle-plugin./build/


Suggested change

/packages/react-native/gradle-plugin./build/

/packages/react-native/gradle-plugin/build/

cortinico · 2022-10-03T11:15:38Z

CHANGELOG.md

@@ -10,7 +10,7 @@
 ### Changed

 - Accept TypeScript type `T | null | undefined` as a maybe type of T in turbo module. ([9ecd203eec](https://github.com/facebook/react-native/commit/9ecd203eec97e7d21d10311d950c9f8f30c7a4b1) by [@ZihanChen-MSFT](https://github.com/ZihanChen-MSFT))
- Bump react-native-gradle-plugin to 0.70.3 ([e33633644c](https://github.com/facebook/react-native/commit/e33633644c70ea39af6e450fcf31d9458051fd5f) by [@dmytrorykun](https://github.com/dmytrorykun))
+- Bump react-native/gradle-plugin. to 0.70.3 ([e33633644c](https://github.com/facebook/react-native/commit/e33633644c70ea39af6e450fcf31d9458051fd5f) by [@dmytrorykun](https://github.com/dmytrorykun))


Let's not edit the CHANGELOG

cortinico · 2022-10-03T11:15:59Z

build.gradle.kts

@@ -34,7 +34,7 @@ allprojects {

 tasks.register("cleanAll", Delete::class.java) {
  description = "Remove all the build files and intermediate build outputs"
-  dependsOn(gradle.includedBuild("react-native-gradle-plugin").task(":clean"))
+  dependsOn(gradle.includedBuild("react-native/gradle-plugin.").task(":clean"))


You should not edit this line as the path is not changing

cortinico · 2022-10-03T11:16:03Z

build.gradle.kts

@@ -53,7 +53,7 @@ tasks.register("cleanAll", Delete::class.java) {

 tasks.register("buildAll") {
  description = "Build and test all the React Native relevant projects."
-  dependsOn(gradle.includedBuild("react-native-gradle-plugin").task(":build"))
+  dependsOn(gradle.includedBuild("react-native/gradle-plugin.").task(":build"))


You should not edit this line as the path is not changing

cortinico · 2022-10-03T11:16:07Z

build.gradle.kts

@@ -67,7 +67,7 @@ tasks.register("buildAll") {

 tasks.register("downloadAll") {
  description = "Download all the depedencies needed locally so they can be cached on CI."
-  dependsOn(gradle.includedBuild("react-native-gradle-plugin").task(":dependencies"))
+  dependsOn(gradle.includedBuild("react-native/gradle-plugin.").task(":dependencies"))


You should not edit this line as the path is not changing

cortinico · 2022-10-03T11:16:15Z

package.json

@@ -128,7 +128,7 @@
    "pretty-format": "^26.5.2",
    "promise": "^8.2.0",
    "react-devtools-core": "^4.26.0",
-    "react-native-gradle-plugin": "^0.71.4",
+    "react-native/gradle-plugin.": "^0.71.4",


Suggested change

"react-native/gradle-plugin.": "^0.71.4",

"react-native/gradle-plugin": "^0.71.4",

cortinico · 2022-10-03T11:16:25Z

packages/react-native-gradle-plugin/README.md

@@ -1,4 +1,4 @@
-# react-native-gradle-plugin
+# react-native/gradle-plugin.


Suggested change

# react-native/gradle-plugin.

# @react-native/gradle-plugin

cortinico · 2022-10-03T11:16:33Z

packages/react-native-gradle-plugin/README.md

@@ -7,10 +7,10 @@ A Gradle Plugin used to support development of React Native applications for And
 ## Installation

 ```
-yarn add react-native-gradle-plugin
+yarn add react-native/gradle-plugin.


Suggested change

yarn add react-native/gradle-plugin.

yarn add @react-native/gradle-plugin

cortinico · 2022-10-03T11:16:58Z

packages/react-native-gradle-plugin/package.json

@@ -1,12 +1,12 @@
 {
-  "name": "react-native-gradle-plugin",
+  "name": "react-native/gradle-plugin.",


Suggested change

"name": "react-native/gradle-plugin.",

"name": "@react-native/gradle-plugin",

This needs to be fixed all over your PR

hoxyq · 2022-11-10T15:15:52Z

Hey @rahul3002,

Thanks for working on this. I am now planning to continue your work and need to introduce some changes, before we can merge this. Can you share if you had any plans onto working on this later or can I just take it?

hoxyq · 2022-11-24T22:33:47Z

Oops, looks like it automatically closed after my push and right now I am unable to push to rahul3002/main
I've pushed just main branch by mistake, so there is no commits, thats why it probably closed

I am also unable to reopen PR now :(

analysis-bot · 2022-11-24T22:39:48Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,561	+0
android	hermes	armeabi-v7a	6,471,886	+0
android	hermes	x86	7,521,203	+0
android	hermes	x86_64	7,380,081	+0
android	jsc	arm64-v8a	8,968,399	+0
android	jsc	armeabi-v7a	7,699,505	+0
android	jsc	x86	9,030,706	+0
android	jsc	x86_64	9,508,749	+0

Base commit: 6a45f2c
Branch: main

analysis-bot · 2022-11-24T23:12:25Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 6a45f2c
Branch: main

pull-bot · 2022-11-24T23:21:58Z

PR build artifact for 4c5eb8d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-24T23:24:11Z

PR build artifact for 4c5eb8d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

rahul3002 requested a review from hramos as a code owner October 1, 2022 12:08

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 1, 2022

cortinico requested changes Oct 3, 2022

View reviewed changes

cortinico mentioned this pull request Oct 4, 2022

☂️ React Native Monorepo #34692

Closed

11 tasks

cortinico added the Tech: Monorepo For PRs that are related to the monorepo infra label Oct 4, 2022

hoxyq closed this Nov 24, 2022

hoxyq force-pushed the main branch from 6a04922 to 4c5eb8d Compare November 24, 2022 22:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… #34835

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… #34835

rahul3002 commented Oct 1, 2022

github-actions bot commented Oct 1, 2022

cortinico left a comment

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

cortinico Oct 3, 2022

hoxyq commented Nov 10, 2022

hoxyq commented Nov 24, 2022 •

edited

Loading

analysis-bot commented Nov 24, 2022

analysis-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

	/packages/react-native/gradle-plugin./build/
	/packages/react-native/gradle-plugin/build/

	"react-native/gradle-plugin.": "^0.71.4",
	"react-native/gradle-plugin": "^0.71.4",

		@@ -1,4 +1,4 @@
		# react-native-gradle-plugin
		# react-native/gradle-plugin.

	yarn add react-native/gradle-plugin.
	yarn add @react-native/gradle-plugin

	"name": "react-native/gradle-plugin.",
	"name": "@react-native/gradle-plugin",

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… #34835

file to Renamed react-native-gradle-plugin to @react-native/gradle-pl… #34835

Conversation

rahul3002 commented Oct 1, 2022

Summary

Changelog

Test Plan

github-actions bot commented Oct 1, 2022

cortinico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoxyq commented Nov 10, 2022

hoxyq commented Nov 24, 2022 • edited Loading

analysis-bot commented Nov 24, 2022

analysis-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

hoxyq commented Nov 24, 2022 •

edited

Loading